Review main Merged

77942[BUGFIX] Fix PHP 8.1 warning in AbstractPlugin

Thomas Hohn CR +2 V +2 Easy +1 −1 updated 02/24/23, 19:16

Commit message

Added a coalescing operator before accessing the value of $wrapper['showResultsNumbersWrap'].

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Thomas Hohn uploaded patch set 1 02/24/23, 12:40

  2. Oliver Klee voted on patch set 1 CR +1 02/24/23, 12:41

  3. Thomas Hohn updated the commit message in patch set 2 CR +1 02/24/23, 12:42

  4. core-ci voted on patch set 2 V +1 02/24/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38054

  5. core-ci voted on patch set 1 V +1 02/24/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38052

  6. Benni Mack voted on patch set 2 V +1 CR +1 02/24/23, 15:21

  7. Georg Ringer voted on patch set 2 V +2 CR +2 02/24/23, 19:16

  8. Georg Ringer merged patch set 3 02/24/23, 19:16