77949[TASK] Deprecate TBE_STYLES stylesheet and stylesheet2
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Sybille Peters +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Georg Ringer +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1722
-
Torben Hansen uploaded patch set 1 02/26/23, 18:52
-
Sybille Peters commented on patch set 1 02/26/23, 19:15
Deprecation-100033-DeprecateTBE_STYLESStylesheetAndStylesheet2.rst:51It would be nice to add the name of the file here. You can use the :caption: directive. That is commonly used in the main docs now to add the file name. Example: .. code-block:: php :caption: EXT:my_extension/ext_tables.php $GLOBALS['TBE_STYLES']['skins']['backend']['stylesheetDirectories']['css'] = 'EXT:backend/Resources/Public/Css/'; -
core-ci voted on patch set 1 V +1 02/26/23, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38128
-
Sybille Peters uploaded patch set 2
V +102/26/23, 19:57 -
Sybille Peters commented on patch set 1 02/26/23, 19:58
Added the :caption: with filename to changelog.Deprecation-100033-DeprecateTBE_STYLESStylesheetAndStylesheet2.rst:51ReplyDone -
core-ci voted on patch set 2 V +1 02/26/23, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38131
-
Torben Hansen uploaded patch set 3
V +102/27/23, 07:46 -
Torben Hansen commented on patch set 2 02/27/23, 07:47
Deprecation-100033-DeprecateTBE_STYLESStylesheetAndStylesheet2.rst:43ReplyThanks for your feedback. I replaced `$nameOfSkin` with `my_extension` in the RST and commit message -
core-ci voted on patch set 3 V +1 02/27/23, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38142
-
Thomas Hohn voted on patch set 3 CR +1 02/27/23, 08:18
-
Georg Ringer commented on patch set 3 02/27/23, 08:19
Deprecation-100033-DeprecateTBE_STYLESStylesheetAndStylesheet2.rst:15CSS stands already for custom stylesheet. suggestion: replace with "custom CSS"Deprecation-100033-DeprecateTBE_STYLESStylesheetAndStylesheet2.rst:38would also create a list just like aboveDeprecation-100033-DeprecateTBE_STYLESStylesheetAndStylesheet2.rst:52please use my_extension instead instead of css -
Torben Hansen uploaded patch set 4
CR +1V +102/27/23, 08:24 -
Torben Hansen commented on patch set 3 02/27/23, 08:25
Deprecation-100033-DeprecateTBE_STYLESStylesheetAndStylesheet2.rst:15ReplyDoneDeprecation-100033-DeprecateTBE_STYLESStylesheetAndStylesheet2.rst:38ReplyDoneDeprecation-100033-DeprecateTBE_STYLESStylesheetAndStylesheet2.rst:52ReplyChanges it to use `my_extension`. The previous example was taken 1:1 from ext:backend. -
core-ci voted on patch set 4 V +1 02/27/23, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38143
-
Thomas Hohn voted on patch set 4 CR +1 02/27/23, 08:33
-
Nikita Hovratov uploaded patch set 5
CR +1V +102/27/23, 08:50 -
Nikita Hovratov voted on patch set 5 V +1 CR +1 02/27/23, 08:50
-
Sybille Peters commented on patch set 5 02/27/23, 08:56
Deprecation-100033-DeprecateTBE_STYLESStylesheetAndStylesheet2.rst:52ReplyShoudn't "backend" be replace with "my_extension" here, not "css"? In gridelements, it is like this: $GLOBALS['TBE_STYLES']['skins']['gridelements']['stylesheetDirectories']['gridelements_structure'] In (outdated) skinning reference: https://docs.typo3.org/m/typo3/reference-skinning/4.5/en-us/BackendCssApi/SkinningApi/Index.html -
core-ci voted on patch set 5 V +1 02/27/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38144
-
Sybille Peters voted on patch set 5 CR +1 02/27/23, 09:00
-
Georg Ringer voted on patch set 5 V +2 CR +2 02/27/23, 09:11
-
Georg Ringer merged patch set 6 02/27/23, 09:11
Deprecation-100033-DeprecateTBE_STYLESStylesheetAndStylesheet2.rst:43