Review 12.1 Merged

77967[TASK] Allow npm version 9.x for node builds

Stefan Bürk CR +2 V +2 Easy +2 −2 updated 03/05/23, 02:01

Commit message

npm version 8.x and 9.x are officially supported for
nodejs 16. Normal npm updates updates from 8 to 9.
Currently npm 9 is disallowed by the version constraint
in the packages.json.

This change allows npm 9 along with npm 8 to be used
to work with npm and dependencies. This allows us to
rebuild the nodejs images without pinning npm down to
npm 8.x.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk commented on patch set 1 03/05/23, 01:43

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/05/23, 01:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38469

  3. Stefan Bürk commented on patch set 1 V +2 CR +2 03/05/23, 02:00

    backported to unblock patch to fix ci on this branch. Needed to get another patch in there (core ci), which is needed in case a security patch must be processed on that branch. But this one is blocking that. core node image has only npm9 and the missing relaxed constraint from this patch is needed therefore. Bending the rules and merging this without votes to get core ci working again for all branches.
  4. Stefan Bürk merged patch set 2 03/05/23, 02:01