Review 11.5 Merged

77971[BUGFIX] Respect TCA field foreign_default_sortby by extbase

Benni Mack CR +2 V +2 Hard +241 −444 updated 03/17/23, 23:26

Commit message

Inside the extbase context child relations are always ordered
by the foreign_sortby field if set or by order of creation.
Even if the field foreign_default_sortby is set, it only
impacts the order of the backend view.

This patch brings the order of extbase results inline with
the order of the backend view.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 1217

  1. Benni Mack commented on patch set 1 03/07/23, 11:49

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMap.php * typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php * typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php
  2. Benni Mack commented on patch set 2 03/07/23, 11:51

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 03/07/23, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38592

  4. core-ci voted on patch set 2 V -1 03/07/23, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38593

  5. JAKOTA Design Group GmbH commented on patch set 2 03/13/23, 13:42

    ColumnMap.php:259

    Do you mind me fixing those merge conflicts or do you have other plans here?
  6. Benni Mack uploaded patch set 3 V -1 03/13/23, 22:20

  7. Benni Mack marked it ready for review 03/13/23, 22:35

  8. Benni Mack commented on patch set 3 03/13/23, 22:42

    we need a new review here, as I had to change quite some parts of it.

    ColumnMap.php:259 Reply

    Done
  9. core-ci voted on patch set 3 V -1 03/13/23, 23:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38892

  10. JAKOTA Design Group GmbH commented on patch set 3 03/14/23, 14:13

    Ok, I'll test this with a 11.5 project that's affected by this bug.

    DataMapper.php:432

    array|null => ?array for php 7.4 I should have written it this way in the main patch anyway.
  11. JAKOTA Design Group GmbH uploaded patch set 4 V -1 03/16/23, 22:22

  12. core-ci voted on patch set 4 V -1 03/16/23, 22:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39081

  13. JAKOTA Design Group GmbH uploaded patch set 5 V -1 03/16/23, 22:35

  14. core-ci voted on patch set 5 V +1 03/16/23, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39084

  15. JAKOTA Design Group GmbH commented on patch set 5 03/16/23, 22:49

    DataMapper.php:432 Reply

    Done
  16. Benni Mack voted on patch set 5 V +2 CR +2 03/17/23, 23:26

  17. Benni Mack merged patch set 6 03/17/23, 23:26