77971[BUGFIX] Respect TCA field foreign_default_sortby by extbase
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 1
Files 8
- Build/phpstan/phpstan-baseline.neon+0 −10
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMap.php2+20 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php+2 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php2+41 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_post.php+1 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/comments.csvnew+7 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php+27 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+143 −431
Review log 1217
-
Benni Mack commented on patch set 1 03/07/23, 11:49
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMap.php * typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php * typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php -
Benni Mack commented on patch set 2 03/07/23, 11:51
Published edit on patch set 1. -
core-ci voted on patch set 1 V -1 03/07/23, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38592
-
core-ci voted on patch set 2 V -1 03/07/23, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38593
-
JAKOTA Design Group GmbH commented on patch set 2 03/13/23, 13:42
ColumnMap.php:259Do you mind me fixing those merge conflicts or do you have other plans here? -
Benni Mack uploaded patch set 3
V -103/13/23, 22:20 -
Benni Mack marked it ready for review 03/13/23, 22:35
-
Benni Mack commented on patch set 3 03/13/23, 22:42
we need a new review here, as I had to change quite some parts of it.ColumnMap.php:259ReplyDone -
core-ci voted on patch set 3 V -1 03/13/23, 23:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38892
-
JAKOTA Design Group GmbH commented on patch set 3 03/14/23, 14:13
Ok, I'll test this with a 11.5 project that's affected by this bug.DataMapper.php:432array|null => ?array for php 7.4 I should have written it this way in the main patch anyway. -
JAKOTA Design Group GmbH uploaded patch set 4
V -103/16/23, 22:22 -
core-ci voted on patch set 4 V -1 03/16/23, 22:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39081
-
JAKOTA Design Group GmbH uploaded patch set 5
V -103/16/23, 22:35 -
core-ci voted on patch set 5 V +1 03/16/23, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39084
-
JAKOTA Design Group GmbH commented on patch set 5 03/16/23, 22:49
DataMapper.php:432ReplyDone -
Benni Mack voted on patch set 5 V +2 CR +2 03/17/23, 23:26
-
Benni Mack merged patch set 6 03/17/23, 23:26