Review main Merged

77974[BUGFIX] Allow POST requests in Workspace previews

Benni Mack CR +2 V +2 Easy +3 −6 updated 03/01/23, 10:10

Commit message

With TYPO3 v9 and site handling, and speaking URLs
that are supported in workspaces, there is no technical
reason to avoid POST requests in Workspaces.

This limitation was added by Kasper in TYPO3 v4.0
in the infamous "tslib_fe" class, whereas the current
code base is much more structured and we can
now safely say, that we have Cookie handling
and POST requests under control via Site Handling,
and middlewares.

This way, forms can be tested and submitted in Workspace
previews.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 02/27/23, 16:35

  2. core-ci voted on patch set 1 V +1 02/27/23, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38162

  3. Benni Mack updated the commit message in patch set 2 V +1 03/01/23, 08:06

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 03/01/23, 08:10

  5. core-ci voted on patch set 2 V +1 03/01/23, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38247

  6. Georg Ringer voted on patch set 2 V +1 CR +1 03/01/23, 08:33

  7. Oliver Klee voted on patch set 2 CR +1 03/01/23, 08:58

  8. Benni Mack voted on patch set 2 V +2 CR +2 03/01/23, 10:10

  9. Benni Mack merged patch set 3 03/01/23, 10:10