Review 11.5 Merged

77975[BUGFIX] Properly validate start module

Thomas Hohn CR +2 V +2 Easy +1 −1 updated 03/01/23, 12:22

Commit message

Fix incorrect handling of result from call to method
$this->moduleLoader->checkMod(). The method has string|array|bool
as return value. The array value is returned in case a valid module
where access is granted exists. The check should be adapted to
reflect this.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Thomas Hohn uploaded patch set 1 02/27/23, 18:45

  2. Thomas Hohn commented on patch set 1 02/27/23, 18:46

    Since the code has been rewritten for main and doesn't contain this error - the patchset is only for 11.5
  3. Thomas Hohn commented on patch set 1 02/27/23, 18:46

    Reply

    Done
  4. core-ci voted on patch set 1 V -1 02/27/23, 18:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38168

  5. Thomas Hohn uploaded patch set 2 V -1 02/27/23, 18:58

  6. core-ci voted on patch set 2 V +1 02/27/23, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38169

  7. Mathias Brodala updated the commit message in patch set 3 V +1 02/28/23, 08:09

  8. core-ci voted on patch set 3 V +1 02/28/23, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38186

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 03/01/23, 12:19

  10. Stefan Bürk voted on patch set 3 V +2 CR +2 03/01/23, 12:22

  11. Stefan Bürk merged patch set 4 03/01/23, 12:22