Review main Merged

77977[TASK] Update display of add/edit scheduler task form

Jasmina Ließmann CR +2 V +2 Hard +257 −126 updated 04/09/23, 20:08

Commit message

Previously, the form fields in the add/edit form of a task were
displayed in their entirety, filling the screen. Additional settings
were placed at the end of the form, so that changes to this area
were usually not visible when the task type was changed.

With this patch, the width of the input mask is now reduced in order
to increase the clarity within the form and to create a uniform
appearance with forms of the form engine. The markup of the
checkboxes has been slightly adjusted, the position of the button for
selecting a start page ('LinkValidator' task) has been corrected and
individual spacing between the form fields has also been adjusted to
match those of the form engine.

In order to better guide the user in the setting steps, the fields
are now grouped into form areas according to their purpose.
Likewise, the fields for advanced settings are moved to a higher
position so that changes in this area are more visible when changing
the task type.

The task type is now also displayed in the edit form.

In general, this patch aligns the add/edit task rendering of the
scheduler module more with FormEngine rendering. Mid-term, this
module should use FormEngine for rendering anyways, so this is
a kind of a pre-patch.

There is a minor glitch when single tasks don't provide additional
fields, now having a lonely heading. We may change this with a
dedicated patch since it's a bit tricky with the current javascript
hide/unhide implemenation of additional fields.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 2338

Show 713 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 02/27/23, 21:38

  2. Jasmina Ließmann uploaded patch set 2 02/27/23, 22:12

  3. core-ci voted on patch set 1 V -1 02/27/23, 22:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38177

  4. core-ci voted on patch set 2 V -1 02/27/23, 23:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38178

  5. Jasmina Ließmann uploaded patch set 3 V -1 03/13/23, 19:15

  6. core-ci voted on patch set 3 V -1 03/13/23, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38888

  7. Jasmina Ließmann uploaded patch set 4 V -1 03/13/23, 21:32

  8. core-ci voted on patch set 4 V -1 03/13/23, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38891

  9. Jasmina Ließmann uploaded patch set 5 V -1 03/27/23, 20:13

  10. core-ci voted on patch set 5 V -1 03/27/23, 20:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39726

  11. Jasmina Ließmann updated the commit message in patch set 6 V -1 03/27/23, 20:32

  12. core-ci voted on patch set 6 V -1 03/27/23, 21:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39728

  13. Jasmina Ließmann uploaded patch set 7 V -1 03/27/23, 21:29

  1. Jasmina Ließmann uploaded patch set 8 03/27/23, 21:36

  2. core-ci voted on patch set 8 V +1 03/27/23, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39733

  3. Jasmina Ließmann uploaded patch set 9 V +1 04/04/23, 14:46

  4. Jasmina Ließmann commented on patch set 9 CR -1 04/04/23, 14:53

    on it
  5. core-ci voted on patch set 9 V +1 04/04/23, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40095

  6. Jasmina Ließmann uploaded patch set 10 CR -1 V +1 04/04/23, 16:22

  7. core-ci voted on patch set 10 V +1 04/04/23, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40102

  8. Annett Jähnichen uploaded patch set 11 V +1 04/06/23, 13:34

  9. core-ci voted on patch set 11 V +1 04/06/23, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40294

  10. Christian Kuhn voted on patch set 11 V +1 CR +1 04/06/23, 18:26

  11. Jasmina Ließmann updated the commit message in patch set 12 CR +1 V +1 04/06/23, 19:22

  12. Christian Kuhn voted on patch set 12 V +1 CR +1 04/06/23, 19:24

  13. Jasmina Ließmann updated the commit message in patch set 13 CR +1 V +1 04/06/23, 19:27

  14. core-ci voted on patch set 12 V +1 04/06/23, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40315

  15. core-ci voted on patch set 13 V +1 04/06/23, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40316

  16. Christian Kuhn voted on patch set 13 V +1 CR +1 04/06/23, 19:49

  17. Christian Kuhn uploaded patch set 14 CR +1 V +1 04/07/23, 13:38

  18. core-ci voted on patch set 14 V +1 04/07/23, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40338

  19. Christian Kuhn uploaded patch set 15 V +1 04/07/23, 13:59

  20. Christian Kuhn uploaded patch set 16 04/07/23, 14:04

  21. Christian Kuhn voted on patch set 16 V +1 CR +1 04/07/23, 14:05

  22. core-ci voted on patch set 15 V +1 04/07/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40343

  23. core-ci voted on patch set 16 V +1 04/07/23, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40347

  24. Benni Mack voted on patch set 16 V +2 CR +2 04/09/23, 20:08

  25. Benni Mack merged patch set 17 04/09/23, 20:08