77981[TASK] Modernize condition matching
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 52
- typo3/sysext/backend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php+10 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+3 −10
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+1 −7
- typo3/sysext/backend/Tests/FunctionalDeprecated/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.phprenamed+1 −1
- typo3/sysext/backend/Tests/FunctionalDeprecated/Fixtures/pages.csvnew+9 −0
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php+2 −0
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcherInterface.php+2 −0
- typo3/sysext/core/Classes/ExpressionLanguage/FunctionsProvider/DefaultFunctionsProvider.php2+57 −42
- typo3/sysext/core/Classes/ExpressionLanguage/FunctionsProvider/Typo3ConditionFunctionsProvider.php4+60 −51
- typo3/sysext/core/Classes/ExpressionLanguage/AbstractProvider.php+8 −13
- typo3/sysext/core/Classes/ExpressionLanguage/DefaultProvider.php+22 −3
- typo3/sysext/core/Classes/ExpressionLanguage/DeprecatingRequestWrapper.phpnew+140 −0
- typo3/sysext/core/Classes/ExpressionLanguage/ProviderConfigurationLoader.php+7 −14
- typo3/sysext/core/Classes/ExpressionLanguage/ProviderInterface.php+0 −3
- typo3/sysext/core/Classes/ExpressionLanguage/RequestWrapper.php+7 −7
- typo3/sysext/core/Classes/ExpressionLanguage/Resolver.php+16 −8
- typo3/sysext/core/Classes/ExpressionLanguage/SiteConditionProvider.phpdeleted+0 −38
- typo3/sysext/core/Classes/ExpressionLanguage/TypoScriptConditionProvider.php+3 −14
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionMatcherVisitor.php+120 −9
- typo3/sysext/core/Classes/TypoScript/PageTsConfigFactory.php+20 −6
Show 32 more files
- typo3/sysext/core/Classes/TypoScript/TypoScriptStringFactory.php+3 −8
- typo3/sysext/core/Classes/TypoScript/UserTsConfigFactory.php+10 −5
- typo3/sysext/core/Configuration/ExpressionLanguage.php+0 −7
- typo3/sysext/core/Configuration/Services.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Deprecation-100047-DeprecatedConditionMatcherClasses.rstnew+50 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Deprecation-100047-PageTsConfigAndUserTsConfigMustNotRelyOnRequest.rstnew+79 −0
- typo3/sysext/core/Tests/Functional/TypoScript/Fixtures/SimpleCondition.typoscriptdeleted+0 −4
- typo3/sysext/core/Tests/Functional/TypoScript/Fixtures/typoScriptStringTextFixture.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/PageTsConfigFactoryTest.php+10 −81
- typo3/sysext/core/Tests/Functional/TypoScript/TypoScriptStringFactoryTest.php+3 −8
- typo3/sysext/core/Tests/Functional/TypoScript/UserTsConfigFactoryTest.php+0 −42
- typo3/sysext/core/Tests/FunctionalDeprecated/TypoScript/Fixtures/userTsConfigTestFixture.csvnew+29 −0
- typo3/sysext/core/Tests/FunctionalDeprecated/TypoScript/PageTsConfigFactoryTest.phpnew+97 −0
- typo3/sysext/core/Tests/FunctionalDeprecated/TypoScript/UserTsConfigFactoryTest.phpnew+66 −0
- typo3/sysext/core/Tests/Unit/ExpressionLanguage/ResolverTest.php+7 −2
- typo3/sysext/core/Tests/UnitDeprecated/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcherTest.phprenamed+25 −7
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+12 −8
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+23 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/Configuration/TypoScript/Basic.typoscript+11 −11
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/Configuration/TypoScript/ExtbasePlugin.typoscript+3 −3
- typo3/sysext/form/Classes/Domain/Condition/Functions/FormConditionFunctionsProvider.php+4 −8
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+5 −3
- typo3/sysext/frontend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php4+22 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+35 −22
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php+3 −8
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/AbsoluteUriPrefixRenderingTest.typoscript+4 −4
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/TitleTagRenderingTest.typoscript+8 −8
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/UriPrefixRenderingTest.typoscript+6 −6
- typo3/sysext/frontend/Tests/FunctionalDeprecated/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.phprenamed+1 −1
- typo3/sysext/frontend/Tests/FunctionalDeprecated/Fixtures/pages.csvnew+9 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+21 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+20 −0
Review log 2541
Show 1016 earlier messages
-
Christian Kuhn uploaded patch set 1 02/28/23, 12:43
-
core-ci voted on patch set 1 V -1 02/28/23, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38204
-
Christian Kuhn uploaded patch set 2
V -102/28/23, 12:58 -
core-ci voted on patch set 2 V -1 02/28/23, 13:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38206
-
Christian Kuhn uploaded patch set 3
V -102/28/23, 13:39 -
Christian Kuhn uploaded patch set 4 02/28/23, 13:44
-
core-ci voted on patch set 3 V -1 02/28/23, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38209
-
core-ci voted on patch set 4 V -1 02/28/23, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38211
-
Christian Kuhn uploaded patch set 5
V -102/28/23, 14:13 -
core-ci voted on patch set 5 V +1 02/28/23, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38214
-
Stefan Bürk commented on patch set 5 02/28/23, 16:50
ConditionMatcher.php:74We should use `?->`here ...ConditionMatcher.php:123We could reuse `$request` here (L110) -
Christian Kuhn uploaded patch set 6
V +102/28/23, 16:51 -
Christian Kuhn commented on patch set 5 02/28/23, 16:53
DefaultFunctionsProvider.php:69ReplyDoneConditionMatcher.php:74ReplyDoneConditionMatcher.php:123ReplyDone -
core-ci voted on patch set 6 V +1 02/28/23, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38219
-
Christian Kuhn uploaded patch set 7
V +102/28/23, 17:26 -
Christian Kuhn uploaded patch set 8 02/28/23, 18:00
-
Christian Kuhn uploaded patch set 9 02/28/23, 18:03
-
core-ci voted on patch set 7 V +1 02/28/23, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38220
-
core-ci voted on patch set 8 V +1 02/28/23, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38222
-
Christian Kuhn uploaded patch set 10 02/28/23, 18:10
-
core-ci voted on patch set 9 V +1 02/28/23, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38223
-
Christian Kuhn uploaded patch set 11 02/28/23, 18:27
-
core-ci voted on patch set 10 V +1 02/28/23, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38225
-
Christian Kuhn uploaded patch set 12 02/28/23, 18:54
-
core-ci voted on patch set 11 V -1 02/28/23, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38228
-
Christian Kuhn uploaded patch set 13 02/28/23, 18:57
-
Christian Kuhn uploaded patch set 14 02/28/23, 18:58
-
core-ci voted on patch set 12 V -1 02/28/23, 19:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38229
-
core-ci voted on patch set 13 V -1 02/28/23, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38230
-
core-ci voted on patch set 14 V +1 02/28/23, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38231
-
Stefan Bürk commented on patch set 14 02/28/23, 20:31
Don't get this ... the `less` is to much here, or ?Typo3ConditionFunctionsProvider.php:56frontendTypo3ConditionFunctionsProvider.php:96frontend -
Christian Kuhn commented on patch set 14 03/01/23, 07:15
Reply
DoneTypo3ConditionFunctionsProvider.php:56ReplyDoneTypo3ConditionFunctionsProvider.php:96ReplyDone -
Christian Kuhn uploaded patch set 15
V +103/01/23, 07:15 -
core-ci voted on patch set 15 V +1 03/01/23, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38244
-
Christian Kuhn uploaded patch set 16
V +103/01/23, 07:24 -
core-ci voted on patch set 16 V +1 03/01/23, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38245
-
Stefan Bürk voted on patch set 16 CR +1 03/01/23, 09:39
-
Stefan Bürk voted on patch set 16 V +1 03/01/23, 10:08
-
Benni Mack voted on patch set 16 V +1 CR +1 03/01/23, 10:10
-
Christian Kuhn voted on patch set 16 V +2 CR +2 03/01/23, 10:21
-
Christian Kuhn merged patch set 17 03/01/23, 10:21
DefaultFunctionsProvider.php:69