Review main Merged

77983[TASK] Migrate new content element wizard to lit

Benjamin Kott CR +2 V +2 Expert +1003 −453 updated 03/06/23, 13:17

Commit message

The new content element wizard is now a custom element with shadow
dom enabled. The reactive component works on the data set assigned.
Every element has a state the component respects and acts accordingly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 35

Show 15 more files

Review log 2638

Show 713 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/28/23, 18:06

  2. core-ci voted on patch set 1 V -1 02/28/23, 18:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38224

  3. Benjamin Kott uploaded patch set 2 V -1 03/01/23, 13:50

  4. Benjamin Kott uploaded patch set 3 03/01/23, 13:58

  5. core-ci voted on patch set 2 V -1 03/01/23, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38266

  6. core-ci voted on patch set 3 V -1 03/01/23, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38267

  7. Benjamin Kott uploaded patch set 4 V -1 03/02/23, 14:37

  8. Benjamin Kott uploaded patch set 5 03/02/23, 14:56

  9. core-ci voted on patch set 4 V -1 03/02/23, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38305

  10. core-ci voted on patch set 5 V -1 03/02/23, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38306

  11. Benjamin Kott uploaded patch set 6 V -1 03/02/23, 15:24

  12. Benjamin Kott uploaded patch set 7 03/02/23, 15:40

  13. core-ci voted on patch set 6 V -1 03/02/23, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38308

  1. core-ci voted on patch set 7 V -1 03/02/23, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38309

  2. Benjamin Kott uploaded patch set 8 V -1 03/03/23, 07:30

  3. core-ci voted on patch set 8 V +1 03/03/23, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38339

  4. Georg Ringer commented on patch set 8 03/03/23, 07:54

    that is really awesome! some nitpicking: - the buttons should IMO have cursor:pointer (left in menu and the selection at the right) I know this is the same as in v11 but maybe could be adjusted as well: - if nothing found with the search, the msg shouldnt be danger but IMO information=blue - would be cool if the tab title would be searchable as well, reason: with news having a dedicated tab with 10 plugins I can avoid having "news" in all labels to be found
  5. Benjamin Kott uploaded patch set 9 V +1 03/03/23, 08:33

  6. Benjamin Kott commented on patch set 9 03/03/23, 08:33

    Reply

    check again
  7. core-ci voted on patch set 9 V +1 03/03/23, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38345

  8. Georg Ringer commented on patch set 9 V +1 CR +1 03/03/23, 11:28

    awesome, great! last nitpick: I suggest to change the commit msg a bit as most users are more affected by the cool UI changes and not so much about the TS internal
  9. Benjamin Kott commented on patch set 9 03/03/23, 12:18

    Reply

    i wanted to cleanup btn-link styling, thats part of what i need for that, sounds crazy, its only a bit reorganized - nothing special. mostly internal ts stuff.
  10. Oli Bartsch commented on patch set 9 CR -1 03/03/23, 14:10

    Review
  11. Andreas Kienast commented on patch set 9 V +1 CR +1 03/03/23, 14:11

    Waiting for Oli Bartsch.
  12. Andreas Kienast commented on patch set 9 V -1 CR 0 03/03/23, 14:25

    Buttons in record list are wider and disabled buttons get a pointer.
  13. Andreas Kienast commented on patch set 9 03/03/23, 15:08

    new-content-element-wizard.ts:425

    this.toggleMenu = !this.toggleMenu

    new-content-element-wizard.ts:531

    you may use `lll()` instead and drop this helper method
  14. Benjamin Kott commented on patch set 9 03/03/23, 15:58

    congratulation we have found a browser bug... this one seems to be related https://bugs.chromium.org/p/chromium/issues/detail?id=953648
  15. Benjamin Kott uploaded patch set 10 CR +1 V +1 03/06/23, 09:52

  16. Benjamin Kott uploaded patch set 11 03/06/23, 09:53

  17. Benjamin Kott commented on patch set 11 03/06/23, 10:03

    new-content-element-wizard.ts:425 Reply

    Done

    new-content-element-wizard.ts:531 Reply

    Done
  18. core-ci voted on patch set 10 V -1 03/06/23, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38529

  19. core-ci voted on patch set 11 V -1 03/06/23, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38531

  20. Benjamin Kott uploaded patch set 12 V -1 03/06/23, 10:43

  21. core-ci voted on patch set 12 V +1 03/06/23, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38542

  22. Andreas Kienast voted on patch set 12 V +1 CR +1 03/06/23, 11:40

  23. Georg Ringer voted on patch set 12 V +1 CR +1 03/06/23, 11:51

  24. Benni Mack voted on patch set 12 V +2 CR +2 03/06/23, 13:17

  25. Benni Mack merged patch set 13 03/06/23, 13:17