77983[TASK] Migrate new content element wizard to lit
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 35
- Build/Sources/Sass/component/_buttons.scss+8 −0
- Build/Sources/Sass/component/_modal.scss+2 −2
- Build/Sources/Sass/component/_resources.scss+0 −3
- Build/Sources/Sass/component/_root.scss+96 −28
- Build/Sources/Sass/component/_statusreport.scss+0 −3
- Build/Sources/Sass/component/_table.scss+15 −4
- Build/Sources/Sass/element/typo3-backend-new-content-element-wizard.scssnew+7 −0
- Build/Sources/Sass/module/_page.scss+0 −53
- Build/Sources/Sass/typo3/_main_new_content_element_wizard.scssdeleted+0 −7
- Build/Sources/Sass/backend.scss+1 −1
- Build/Sources/TypeScript/backend/element/icon-element.ts+1 −0
- Build/Sources/TypeScript/backend/enum/icon-types.ts+2 −1
- Build/Sources/TypeScript/backend/context-menu-actions.ts+15 −18
- Build/Sources/TypeScript/backend/modal.ts+10 −0
- Build/Sources/TypeScript/backend/new-content-element-wizard-button.ts+10 −21
- Build/Sources/TypeScript/backend/new-content-element-wizard.ts4+501 −160
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+29 −27
- typo3/sysext/backend/Classes/Tree/View/AbstractContentPagePositionMap.php+2 −2
- typo3/sysext/backend/Classes/Tree/View/ContentCreationPagePositionMap.php+3 −2
- typo3/sysext/backend/Classes/Tree/View/ContentMovingPagePositionMap.php+7 −14
Show 15 more files
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+1 −1
- typo3/sysext/backend/Resources/Private/Partials/NewContentElement/MenuItem.htmldeleted+0 −33
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/PositionMap.html+4 −6
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/Wizard.html+6 −52
- typo3/sysext/backend/Resources/Public/Css/backend.css+3 −3
- typo3/sysext/backend/Resources/Public/JavaScript/element/icon-element.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/enum/icon-types.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/new-content-element-wizard-button.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/new-content-element-wizard.js+256 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+8 −0
- typo3/sysext/core/Resources/Private/Language/locallang_misc.xlf+3 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FalMetadataCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlineContentElementLocalizeSynchronizeCest.php+5 −3
Review log 2638
Show 713 earlier messages
-
Benjamin Kott uploaded patch set 1 02/28/23, 18:06
-
core-ci voted on patch set 1 V -1 02/28/23, 18:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38224
-
Benjamin Kott uploaded patch set 2
V -103/01/23, 13:50 -
Benjamin Kott uploaded patch set 3 03/01/23, 13:58
-
core-ci voted on patch set 2 V -1 03/01/23, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38266
-
core-ci voted on patch set 3 V -1 03/01/23, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38267
-
Benjamin Kott uploaded patch set 4
V -103/02/23, 14:37 -
Benjamin Kott uploaded patch set 5 03/02/23, 14:56
-
core-ci voted on patch set 4 V -1 03/02/23, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38305
-
core-ci voted on patch set 5 V -1 03/02/23, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38306
-
Benjamin Kott uploaded patch set 6
V -103/02/23, 15:24 -
Benjamin Kott uploaded patch set 7 03/02/23, 15:40
-
core-ci voted on patch set 6 V -1 03/02/23, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38308
-
core-ci voted on patch set 7 V -1 03/02/23, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38309
-
Benjamin Kott uploaded patch set 8
V -103/03/23, 07:30 -
core-ci voted on patch set 8 V +1 03/03/23, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38339
-
Georg Ringer commented on patch set 8 03/03/23, 07:54
that is really awesome! some nitpicking: - the buttons should IMO have cursor:pointer (left in menu and the selection at the right) I know this is the same as in v11 but maybe could be adjusted as well: - if nothing found with the search, the msg shouldnt be danger but IMO information=blue - would be cool if the tab title would be searchable as well, reason: with news having a dedicated tab with 10 plugins I can avoid having "news" in all labels to be found -
Benjamin Kott uploaded patch set 9
V +103/03/23, 08:33 -
Benjamin Kott commented on patch set 9 03/03/23, 08:33
Reply
check again -
core-ci voted on patch set 9 V +1 03/03/23, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38345
-
Georg Ringer commented on patch set 9 V +1 CR +1 03/03/23, 11:28
awesome, great! last nitpick: I suggest to change the commit msg a bit as most users are more affected by the cool UI changes and not so much about the TS internal -
Benjamin Kott commented on patch set 9 03/03/23, 12:18
Reply
i wanted to cleanup btn-link styling, thats part of what i need for that, sounds crazy, its only a bit reorganized - nothing special. mostly internal ts stuff. -
Oli Bartsch commented on patch set 9 CR -1 03/03/23, 14:10
Review -
Andreas Kienast commented on patch set 9 V +1 CR +1 03/03/23, 14:11
Waiting for Oli Bartsch. -
Andreas Kienast commented on patch set 9 V -1 CR 0 03/03/23, 14:25
Buttons in record list are wider and disabled buttons get a pointer. -
Andreas Kienast commented on patch set 9 03/03/23, 15:08
new-content-element-wizard.ts:425this.toggleMenu = !this.toggleMenunew-content-element-wizard.ts:531you may use `lll()` instead and drop this helper method -
Benjamin Kott commented on patch set 9 03/03/23, 15:58
congratulation we have found a browser bug... this one seems to be related https://bugs.chromium.org/p/chromium/issues/detail?id=953648 -
Benjamin Kott uploaded patch set 10
CR +1V +103/06/23, 09:52 -
Benjamin Kott uploaded patch set 11 03/06/23, 09:53
-
Benjamin Kott commented on patch set 11 03/06/23, 10:03
new-content-element-wizard.ts:425ReplyDonenew-content-element-wizard.ts:531ReplyDone -
core-ci voted on patch set 10 V -1 03/06/23, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38529
-
core-ci voted on patch set 11 V -1 03/06/23, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38531
-
Benjamin Kott uploaded patch set 12
V -103/06/23, 10:43 -
core-ci voted on patch set 12 V +1 03/06/23, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38542
-
Andreas Kienast voted on patch set 12 V +1 CR +1 03/06/23, 11:40
-
Georg Ringer voted on patch set 12 V +1 CR +1 03/06/23, 11:51
-
Benni Mack voted on patch set 12 V +2 CR +2 03/06/23, 13:17
-
Benni Mack merged patch set 13 03/06/23, 13:17