Review main Merged

77986[TASK] Add return type hints to some GeneralUtility methods

Christian Kuhn CR +2 V +2 Easy +7 −7 updated 03/01/23, 09:40

Commit message

Add return type hints to the IP comparison
related methods in GeneralUtility.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 03/01/23, 07:53

  2. core-ci voted on patch set 1 V +1 03/01/23, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38246

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 03/01/23, 08:54

  4. Oliver Klee voted on patch set 1 CR +1 03/01/23, 08:57

  5. Oliver Klee voted on patch set 1 V +1 03/01/23, 08:57

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 03/01/23, 09:40

  7. Christian Kuhn merged patch set 2 03/01/23, 09:40