Review 11.5 Merged

77989[BUGFIX] Handle getFileContents in LocalDriver better

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 03/01/23, 11:52

Commit message

The method getFileContents has return value string. But since
there is no guarantee that the file exists before calling
file_get_contents, a call to is_readable has been added.
This handles both the PHP Warning and ensures type correctness.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 03/01/23, 11:26

  2. core-ci voted on patch set 1 V +1 03/01/23, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38259

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 03/01/23, 11:52

  4. Christian Kuhn merged patch set 2 03/01/23, 11:52