77997[FEATURE] Introduce Content Security Policy headers
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Markus Klein +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Markus Klein +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 51
- typo3/sysext/backend/Classes/Middleware/ContentSecurityPolicyHeaders.php4new+69 −0
- typo3/sysext/backend/Classes/Template/PageRendererBackendSetupTrait.php+4 −0
- typo3/sysext/backend/Configuration/ContentSecurityPolicies.php2new+38 −0
- typo3/sysext/backend/Configuration/RequestMiddlewares.php7+8 −1
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+23 −9
- typo3/sysext/core/Classes/Core/RequestId.php5+10 −4
- typo3/sysext/core/Classes/Http/Security/ReferrerEnforcer.php+9 −3
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php2+29 −0
- typo3/sysext/core/Classes/Page/ImportMap.php+6 −4
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php2+12 −5
- typo3/sysext/core/Classes/Page/PageRenderer.php2+24 −5
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Event/PolicyMutatedEvent.php2new+76 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Directive.phpnew+102 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/ModelService.php2new+117 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Mutation.php5new+56 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/MutationCollection.php4new+41 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/MutationMode.php4new+28 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/MutationOrigin.phpnew+31 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/MutationOriginType.phpnew+24 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Policy.php2new+233 −0
Show 31 more files
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/PolicyProvider.php6new+117 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/RawValue.php2new+36 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Scope.php2new+121 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/SourceCollection.php4new+126 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/SourceKeyword.phpnew+73 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/SourceScheme.phpnew+30 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/UriValue.phpnew+91 −0
- typo3/sysext/core/Classes/Utility/DebugUtility.php+7 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+3 −2
- typo3/sysext/core/Classes/ServiceProvider.php+7 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+2 −3
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+6 −0
- typo3/sysext/core/Configuration/FactoryConfiguration.php+3 −0
- typo3/sysext/core/Configuration/Services.yaml2+7 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-99499-IntroduceContent-Security-PolicyHandling.rst6new+160 −0
- typo3/sysext/core/Tests/Acceptance/Support/Extension/ApplicationEnvironment.php+3 −13
- typo3/sysext/core/Tests/Unit/Http/Security/ReferrerEnforcerTest.php+31 −3
- typo3/sysext/core/Tests/Unit/Security/ContentSecurityPolicy/PolicyTest.phpnew+145 −0
- typo3/sysext/core/Tests/Unit/Security/ContentSecurityPolicy/ScopeTest.phpnew+105 −0
- typo3/sysext/core/Tests/Unit/Security/ContentSecurityPolicy/UriValueTest.phpnew+59 −0
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php+12 −2
- typo3/sysext/extbase/Tests/Unit/Utility/Fixtures/DebuggerUtilityAccessibleProxy.phpnew+36 −0
- typo3/sysext/extbase/Tests/Unit/Utility/DebuggerUtilityTest.php+15 −0
- typo3/sysext/filelist/Configuration/ContentSecurityPolicies.php2new+42 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Security/NonceViewHelper.php3new+52 −0
- typo3/sysext/frontend/Classes/Middleware/ContentSecurityPolicyHeaders.php4new+70 −0
- typo3/sysext/frontend/Configuration/ContentSecurityPolicies.php2new+30 −0
- typo3/sysext/frontend/Configuration/RequestMiddlewares.php+8 −0
- typo3/sysext/install/Classes/Controller/ControllerTrait.phpnew+49 −0
- typo3/sysext/install/Classes/Controller/InstallerController.php+6 −1
- typo3/sysext/install/Classes/Controller/LayoutController.php+6 −1
Review log 91124
Show 7299 earlier messages
-
Oliver Hader uploaded patch set 1 03/01/23, 22:05
-
core-ci voted on patch set 1 V +1 03/01/23, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38276
-
Simon Schaufelberger commented on patch set 1 03/01/23, 22:34
corresponding... response...Important-99499-EnforceBackendContent-Security-Policy.rst:13too many empty lines -
Oliver Hader commented on patch set 1 03/01/23, 22:44
Important-99499-EnforceBackendContent-Security-Policy.rst:13ReplyAh, seems like I forgot to add some details here... -
Benni Mack commented on patch set 1 03/02/23, 07:00
any chance we can make this non-breaking? e.g. by a) setting DefaultConfiguration to false, but to true in FactoryConfiguration b) provide an UpgradeWizard (or 2, one for BE and FE) to enable the flag with a note on what this change means? -
Oliver Hader commented on patch set 1 03/02/23, 07:57
Reply
Factory default sounds good to me -
Oliver Hader uploaded patch set 2
V +103/02/23, 08:07 -
Oliver Hader commented on patch set 2 03/02/23, 08:08
Reply
Done, now only enabled via factory defaults for the backend scopeReply
DoneImportant-99499-EnforceBackendContent-Security-Policy.rst:13ReplyDone, file has been removed -
Georg Ringer voted on patch set 2 CR +1 03/02/23, 08:13
-
core-ci voted on patch set 2 V +1 03/02/23, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38293
-
Christian Kuhn commented on patch set 1 03/02/23, 08:17
ContentSecurityPolicyHeaders.php:34final, probably. there shouldn't be a reason to extend middlewares.ContentSecurityPolicies.php:15a summary what this default be configuration does and achieves wouldn't hurt i suppose.RequestId.php:27i really prefer non-public properties paired with getters: those are much easier to deprecate in the getter in case we ever need to get rid of them. i think we should mainly try to avoid public properties throughout the framework for this reason.RequestId.php:32this is not identical to before: $this->short is now a raw binary string, while md5() by default returns character range.PageRenderer.php:844could we maybe protect this? or maybe at least mark @internal? feels as if it would be better if we don't directly make this API, or is there no way around that in PageRenderer? Also, a comment this thing is CSP related wouldn't hurt.PolicyMutatedEvent.php:36as with other classes: i'd really prefer protected / private properties to mitigate possible future deprecation problems. have getters for listeners instead.ModelService.php:25maybe final, maybe @internal for now?Mutation.php:26maybe final, maybe @internal for now?Mutation.php:31as with other classes: i'd really prefer protected / private properties to mitigate possible future deprecation problems.MutationCollection.php:20a class comment on where / how this class is used could be helpful. maybe final, maybe @internal for now?MutationCollection.php:25as with other classes: i'd really prefer protected / private properties to mitigate possible future deprecation problems.MutationMode.php:20a comment on where / how this is used and what this class is good for could be helpful. maybe final, maybe @internal for now?Policy.php:27final probably, @internal eventually (at least for now?)PolicyProvider.php:30final maybe, @internal eventually (maybe at least for now?)PolicyProvider.php:32as with other classes: i'd really prefer protected / private properties to mitigate possible future deprecation problems.RawValue.php:26finaly probably?Scope.php:29final, probably? @internal eventually?SourceCollection.php:22final eventually? maybe @internal (in general: see where we could / should @internal throughout the patch) also, a class comment wouldn't hurt, but may not be critical here.SourceCollection.php:27as with other classes: i'd really prefer protected / private properties to mitigate possible future deprecation problems.WeakMapUtility.php:21using the class name as explanation of the class does not add much value. could we add some more info here on what this class is for, where it's typically used and in which scope it's supposed to be used?WeakMapUtility.php:23final? it's static anyways ...ContentSecurityPolicies.php:14a summary comment on the goal of this backend related configuration could be helpful.NonceViewHelper.php:54do not rely on $GLOBALS['TYPO3_REQUEST'], please refactor so it's not needed.ContentSecurityPolicyHeaders.php:34could be declared final as well? there shouldn't be a good reason to extend the middleware.ContentSecurityPolicies.php:15a comment outlining goals of this default FE configuration could be helpful. -
Christian Kuhn commented on patch set 2 CR -1 03/02/23, 08:18
-1 for now ... had a rough look on reading and left a series of comments. -
Oliver Hader uploaded patch set 3
CR +1V +103/02/23, 10:06 -
Oliver Hader commented on patch set 2 03/02/23, 10:09
Concerning using `public readonly $property` we should find a general consensus with all devs. I see the point that deprecating properties gets a bit more complicated (still, it is still possible though). On the other hand a lot of stupid boiler plate code can be omitted, which is just used for the eventual case that something might(!) be deprecated in the future.ContentSecurityPolicyHeaders.php:34ReplyFine, I don't have a preference here. Are there other middlewares that are `final` already?ContentSecurityPolicies.php:15ReplyLike reading all the comments below instead?RequestId.php:27ReplyI really prefer public readonly properties instead of using superfluous boilerplate code with getters... in this scenario `RequestId` is marked `@internal`. Why should that be deprecated instead of removed/adjusted?! Anyway, if it has to be getters, so be it... I don't really care...RequestId.php:32ReplyNo true, see the `bin2hex`PageRenderer.php:844ReplyI'll drop it...ModelService.php:25ReplyDoneMutation.php:26ReplyPeople are supposed to use it... ´@internal` would not make much sense hereMutationCollection.php:20ReplyDoneMutationMode.php:20ReplyEnums can be `final`?Policy.php:27Reply`@internal` is fine, but not `final`.PolicyProvider.php:30Reply`final` since it's an injected providerRawValue.php:26ReplyNoScope.php:29ReplyDoneSourceCollection.php:22ReplyDoneWeakMapUtility.php:21ReplyI really have no clue what you're expecting here? Please provide a suggestion instead of ranting, thx!WeakMapUtility.php:23ReplyDoneContentSecurityPolicies.php:14ReplyDoneNonceViewHelper.php:54ReplyHow to pass that kind of information globally then? There are still zillions of usages for `site`, `normalizeParams`, `lang` and any other stuff that is relying on `$GLOBALS['TYPO3_REQUEST']`... I dropped it with being less flexible as a consequence...ContentSecurityPolicyHeaders.php:34ReplyFine, I don't have a preference here. Are there other middlewares that are `final` already?ContentSecurityPolicies.php:15ReplyDone -
core-ci voted on patch set 3 V +1 03/02/23, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38296
-
Oliver Hader uploaded patch set 4
V +103/02/23, 11:28 -
core-ci voted on patch set 4 V +1 03/02/23, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38297
-
Christian Kuhn commented on patch set 4 03/02/23, 11:54
Reply
I expected an answer like that. I think we should raise this in coredev channel to decide on this, there are reasons for both. I guess we agree that we have to be able to deprecate things, even if we currently don't know things have to be deprecated later again. You're right: access to public (readonly?!) typed properties *can* be deprecated, we have this public property trait for it. However, this trait is pretty ugly, it needs a class property with a list of properties, and it (afaik?) does not work with static stuff. It's easier with getters: add a trigger_error() to the method with some deprecation message and done. And it's obvious on reading. From a framework point of view, that's more elegant. Until now, we rather tried to avoid public API properties in new code, but I don't insist on this view. Let's get a decision via chat once and for all, and if it's fine, then maybe with an advise on when it's ok (maybe for readonly properties only) and when it's not ok?ContentSecurityPolicyHeaders.php:34Replyexisting middlewares may not be all final currently, but new ones definately should be, imho.RequestId.php:27Replylet's continue on the patch set comment and mark this comment done.Mutation.php:26Replyack.MutationMode.php:20Replyactually unsure. keep as is, sorry.WeakMapUtility.php:21Replyok, ignore. I've read up on \WeakMap again and understand it better now. It's a rather new and not so well known construct, so I thought some explanation on it wouldn't hurt.ContentSecurityPolicyHeaders.php:34Replyexisting ones are probably not (all?) final, but new ones should be. -
Oliver Hader commented on patch set 4 03/02/23, 12:40
Reply
I'm just pasting an example here, to get a feeling what it would take to deprecate a `public readonly $property`. Using `PublicPropertyDeprecationTrait` is a bit different, but from my point of view not complicated. Base class: ``` class DemoSubject { public readonly string $value; public function __construct() { $this->value = 'demo'; } } ``` Deprecating `$value` requires to add the trait, change `public → protected`, and finally add `@deprecated` and a corresponding message (last aspect would be the same for `getValue()` as well): ``` class DemoSubject { use PublicPropertyDeprecationTrait; /** @deprecated */ protected readonly string $value; /** @var array<string, string> */ protected array $deprecatedPublicProperties = [ 'value' => self::class . '::$value is deprecated', ]; public function __construct() { $this->value = 'demo'; } } ``` And the same deprecation when using `getValue()` instead of direct `$subject->value` access: ``` class DemoSubject { /** @deprecated */ protected readonly string $value; public function __construct() { $this->value = 'demo'; } /** @deprecated */ public function getValue(): string { trigger_error(self::class . '::$value is deprecated', E_USER_DEPRECATED); return $this->value; } } ```ContentSecurityPolicyHeaders.php:34ReplyAckMutationMode.php:20ReplyEnums cannot be extended, they do not support the concept of inheritance.ContentSecurityPolicyHeaders.php:34ReplyAck -
Oliver Hader commented on patch set 4 03/02/23, 12:52
Reply
Finally, I hope that PHP folks would pick up https://wiki.php.net/rfc/property_accessors again for future versions. -
Christian Kuhn commented on patch set 4 03/03/23, 10:01
NonceViewHelper.php:54Replyrequest is incoming in arguments with fluid typo3 context. see other VH's -
Oliver Hader updated the commit message in patch set 5
V +103/07/23, 10:33 -
Georg Ringer voted on patch set 5 V +1 CR +1 03/07/23, 11:46
-
core-ci voted on patch set 5 V -1 03/07/23, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38588
-
core-ci commented on patch set 5 03/07/23, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38588
-
Oliver Hader rebased onto patch set 6
CR +1V +103/07/23, 15:14 -
core-ci voted on patch set 6 V +1 03/07/23, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38609
-
Georg Ringer voted on patch set 6 V +1 CR +1 03/07/23, 15:31
-
Oliver Hader uploaded patch set 7 03/07/23, 17:37
Copied Votes: * Code-Review+1 (copy condition: "changekind:NO_CHANGE OR is:MIN") * Verified+1 (copy condition: "changekind:NO_CHANGE") -
Benjamin Franzke voted on patch set 7 CR +1 03/07/23, 17:39
-
core-ci voted on patch set 7 V +1 03/07/23, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38618
-
Markus Klein commented on patch set 7 03/08/23, 14:30
JavaScriptRenderer.php:110?string -
Markus Klein commented on patch set 7 03/08/23, 14:36
Feature-99499-IntroduceContent-Security-PolicyHandling.rst:16canFeature-99499-IntroduceContent-Security-PolicyHandling.rst:27flags -
Markus Klein commented on patch set 8
CR +1V +103/08/23, 14:41Published edit on patch set 7. -
Markus Klein commented on patch set 8 03/08/23, 14:41
JavaScriptRenderer.php:110ReplyDoneFeature-99499-IntroduceContent-Security-PolicyHandling.rst:16ReplyDoneFeature-99499-IntroduceContent-Security-PolicyHandling.rst:27ReplyDone -
core-ci voted on patch set 8 V +1 03/08/23, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38657
-
Oliver Hader uploaded patch set 9
V +103/08/23, 18:10 -
core-ci voted on patch set 9 V -1 03/08/23, 18:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38665
-
Oliver Hader uploaded patch set 10
V -103/09/23, 08:53 -
core-ci voted on patch set 10 V -1 03/09/23, 09:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38680
-
Torben Hansen commented on patch set 10 03/09/23, 09:13
I tried to verify, that a custom CSP will have a higher priority that a CSP defined in configuration trough this feature. In frontend scope, this works fine and a CSP header defined in `config.additionalHeaders` TypoScript has priority and is used instead of one configured in site settings. For backend scope, this does not seem to work in my test environment. I have configured a custom CSP for the backend using the following settings in `additional.php`: ``` $GLOBALS['TYPO3_CONF_VARS']['BE']['HTTP']['Response']['Headers'] = [ 'Content-Security-Policy: default-src \'self\'', ]; ``` I would now expect, that my custom CSP will be used, since the `ContentSecurityPolicyHeaders` middleware is called after the `AdditionalResponseHeaders` middleware. This is however not the case and the response object has now 2 CSP headers (my own and the one from the `ContentSecurityPolicyHeaders`) resulting in a CSP header containing a mix of my custom and the `ContentSecurityPolicyHeaders` CSP.. When `$response = $handler->handle($request);` is called in `AdditionalResponseHeaders` middleware, the `ContentSecurityPolicyHeaders` middleware is executed and at this point, no configured BE response headers have been added. -
Oliver Hader commented on patch set 10 03/09/23, 10:49
Reply
Good catch! Both middlewares are focussing on the response (not on the request). Thus, their order had to be switched. -
Oliver Hader uploaded patch set 11
V -103/09/23, 10:49 -
Oliver Hader uploaded patch set 12 03/09/23, 11:09
-
core-ci voted on patch set 11 V -1 03/09/23, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38691
-
core-ci voted on patch set 12 V +1 03/09/23, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38692
-
Benjamin Kott uploaded patch set 13
V +103/09/23, 16:32 -
core-ci voted on patch set 13 V -1 03/09/23, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38705
-
Oliver Hader uploaded patch set 14
V -103/09/23, 16:44 -
core-ci voted on patch set 14 V +1 03/09/23, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38707
-
Oliver Hader commented on patch set 14 03/09/23, 17:09
One thing is missing for `lit` elements defining their own styles, see https://github.com/lit/lit/pull/2134 -
Oliver Hader uploaded patch set 15
V +103/10/23, 10:26 -
core-ci voted on patch set 15 V -1 03/10/23, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38763
-
Oliver Hader uploaded patch set 16
V -103/10/23, 15:04 -
core-ci voted on patch set 16 V +1 03/10/23, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38775
-
Markus Klein commented on patch set 16 03/10/23, 21:21
RequestMiddlewares.php:101Why is this adjustment needed? -
Oliver Hader commented on patch set 16 03/10/23, 21:28
RequestMiddlewares.php:101Reply`typo3/cms-backend/response-headers` might extend the response headers with `Content-Security-Policy`, `typo3/cms-backend/csp-headers` is checking that previous response. Middleware order is focussed on the request(!), however when focussing on the response(!) the order is in reverse order. The onion chain looks like this: ``` invoke typo3/cms-backend/csp-headers → handle request(!) → invoke typo3/cms-backend/response-headers → handle request(!) → invoke additional middlewares/handlers → ... → extend response(!) → check and extend response(!) ``` -
Oliver Hader commented on patch set 16 03/10/23, 21:31
RequestMiddlewares.php:101Replyfor response-propagation it also could stay like that, but then csp-headers needs to have an additional order setting concerning response-propagation - which seems to be better → I'll adjust it there -
Markus Klein commented on patch set 16 03/10/23, 21:37
RequestMiddlewares.php:101ReplyI'm fully aware of the order principle here. But currently we have a strict order relationship between response-headers -> response-propagation. If this relation is relaxed, the order of these two might switch inadvertently. That's why I was asking. Just to avoid side effects -
Oliver Hader commented on patch set 16 03/10/23, 21:39
RequestMiddlewares.php:101ReplyI see. I'm changing this to use only `after` and omitting confusion with `before`. -
Oliver Hader uploaded patch set 17
V +103/10/23, 21:40 -
Oliver Hader commented on patch set 17 03/10/23, 21:43
RequestMiddlewares.php:101ReplyDone -
Markus Klein commented on patch set 17 CR +1 03/10/23, 21:43
RequestMiddlewares.php:101ReplyAck -
core-ci voted on patch set 17 V +1 03/10/23, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38779
-
Oliver Hader commented on patch set 17 03/10/23, 22:09
Services.yaml:528`shared` can be removed -
Torben Hansen commented on patch set 17 V +1 CR +1 03/11/23, 06:16
Feature-99499-IntroduceContent-Security-PolicyHandling.rst:93Unused import -
Oliver Hader uploaded patch set 18
CR +1V +103/11/23, 11:06 -
Oliver Hader commented on patch set 18 03/11/23, 11:10
PolicyMutatedEvent.php:36ReplyMutation.php:31ReplyMutationCollection.php:25ReplyPolicyProvider.php:32ReplySourceCollection.php:27ReplyServices.yaml:528ReplyDoneFeature-99499-IntroduceContent-Security-PolicyHandling.rst:93ReplyDone -
core-ci voted on patch set 18 V -1 03/11/23, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38790
-
Oliver Hader uploaded patch set 19
V -103/11/23, 12:51 -
core-ci voted on patch set 19 V +1 03/11/23, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38792
-
Markus Klein voted on patch set 19 CR +1 03/11/23, 13:24
-
Torben Hansen voted on patch set 19 V +1 CR +1 03/11/23, 13:41
-
Markus Klein voted on patch set 19 V +1 03/13/23, 11:56
-
Georg Ringer voted on patch set 19 V +1 CR +1 03/14/23, 04:06
-
Oliver Hader commented on patch set 19 CR -1 03/14/23, 19:54
Okay, \WeakMap is probably not what I thought it is... PHP emphasized "weak" over "map": → https://3v4l.org/TSO37#v8.1.16 It works for enums as keys, but real objects will disappear when leaving the call-hierarchy scope. -
Oliver Hader commented on patch set 19 V -1 03/14/23, 21:20
→ `\WeakMap` replacement, please review https://review.typo3.org/c/Packages/TYPO3.CMS/+/78127 first -
Oliver Hader uploaded patch set 20
CR +1V +103/14/23, 21:37 -
Oliver Hader uploaded patch set 21 03/14/23, 21:40
-
core-ci voted on patch set 21 V +1 03/14/23, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38951
-
Oliver Hader rebased onto patch set 22
V +103/14/23, 22:41 -
core-ci voted on patch set 22 V +1 03/14/23, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38954
-
Oliver Hader rebased onto patch set 23
V +103/15/23, 09:15 -
Benni Mack commented on patch set 23 03/15/23, 09:21
ApplicationScope.php:23we already have something called "ApplicationType" - should re-use that? Or at least bring them closer together? I mean, we use the abbrevation extensively everywhere. If you want to keep the applicationScope enum, we should at least move it to TYPO3\CMS\Core\Core as this thing does not have anything to do with Http. -
core-ci voted on patch set 23 V +1 03/15/23, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38961
-
Oliver Hader uploaded patch set 24 03/15/23, 09:25
Copied Votes: * Verified+1 (copy condition: "changekind:NO_CHANGE") -
core-ci voted on patch set 24 V +1 03/15/23, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38962
-
Oliver Hader commented on patch set 24 03/15/23, 09:39
ApplicationScope.php:23Reply`ApplicationType->$type` is not specific enough, it has a bit-mask that in theory would allow all values. Thus, current `ApplicationType` could be frontend, backend, CLI and install-tool at the same time - I want to avoid that ;-) In general I like the idea of having just one `ApplicationType` or `ApplicationScope` from a semantic point of view. -
Oliver Hader uploaded patch set 25
V +103/15/23, 09:48 -
core-ci voted on patch set 25 V +1 03/15/23, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38966
-
Oliver Hader commented on patch set 25 03/15/23, 10:21
ApplicationScope.php:23ReplyI've created a draft at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78129 changing `ApplicationType` from `class` to `enum`. Which seems doable, since the constructor was private and the `$type` property was not exposed. -
Oliver Hader commented on patch set 25 03/15/23, 10:54
ApplicationScope.php:23ReplyDone -
Oliver Hader uploaded patch set 26
V +103/15/23, 10:55 -
core-ci voted on patch set 26 V +1 03/15/23, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38973
-
Oliver Hader commented on patch set 27
V +103/15/23, 11:17Published edit on patch set 26. -
core-ci voted on patch set 27 V +1 03/15/23, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38975
-
Markus Klein commented on patch set 27 03/15/23, 11:59
AbstractServiceProvider.php:168?string -
Markus Klein commented on patch set 27 03/15/23, 12:00
my comment is just one example, we have multiple places where we have optional params where the type is not nullable. I guess we should have nullable, right? -
Oliver Hader commented on patch set 27 03/15/23, 12:09
Reply
What file/class are you referring to?
-
Oliver Hader commented on patch set 27 03/15/23, 12:17
Reply
Ah got it, did not see the other comment. `function(string $value = null)` is okay in current PHP versions. I guess that might change in future PHP version to be strict and use only `?string $value = null`. That also would be something for php-cs-fixer. -
Oliver Hader uploaded patch set 28
V +103/15/23, 12:17 -
Oliver Hader commented on patch set 28 03/15/23, 12:18
Extracted site configuration from `config.yaml` to new `csp.yaml` file. -
Markus Klein commented on patch set 28 03/15/23, 13:03
Reply
Ack -
Markus Klein commented on patch set 28 03/15/23, 13:04
AbstractServiceProvider.php:168ReplyAck -
core-ci voted on patch set 28 V -1 03/15/23, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38979
-
Oliver Hader uploaded patch set 29
V -103/15/23, 13:22 -
Oliver Hader commented on patch set 29 03/15/23, 13:23
Classic! I forgot to amend the the new class... -
core-ci voted on patch set 29 V +1 03/15/23, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38983
-
Benni Mack uploaded patch set 30
V +103/15/23, 19:46 -
Benni Mack uploaded patch set 31 03/15/23, 19:54
-
core-ci voted on patch set 30 V -1 03/15/23, 20:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39004
-
Benni Mack uploaded patch set 32 03/15/23, 20:17
-
Benni Mack commented on patch set 32 03/15/23, 20:19
PolicyProvider.php:93I wonder if we should inheritDefault as "true" by default. WDYT -
Benni Mack commented on patch set 32 03/15/23, 20:19
Reply
Not relevant now. -
core-ci voted on patch set 31 V -1 03/15/23, 20:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39005
-
core-ci voted on patch set 32 V +1 03/15/23, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39008
-
Oliver Hader uploaded patch set 33
V +103/15/23, 20:56 -
Oliver Hader commented on patch set 32 03/15/23, 20:57
PolicyProvider.php:93Reply👍 -
core-ci voted on patch set 33 V +1 03/15/23, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39011
-
Benni Mack voted on patch set 33 V +1 CR +1 03/15/23, 21:35
-
Markus Klein voted on patch set 33 CR +1 03/15/23, 21:56
-
Markus Klein commented on patch set 33 V +1 03/15/23, 22:47
I tested as much as I could, lets get this in and tweak things afterwards if anything should pop up. Thanks for all the work! -
Oliver Hader commented on patch set 33 V +2 CR +2 03/16/23, 00:31
Thanks for all of your reviews, tests and feedback! 👌 -
Oliver Hader merged patch set 34 03/16/23, 00:32