Review 11.5 Merged

78003[BUGFIX] Fix PHP 8 warning in ImageResourceContentObject

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 03/02/23, 14:42

Commit message

Added null coalescing operator in case $lastImgResourceInfo[3]
is not set.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 03/02/23, 13:11

  2. core-ci voted on patch set 1 V -1 03/02/23, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38299

  3. Thomas Hohn commented on patch set 1 03/02/23, 13:26

    ImageResourceContentObject.php:18

    Not use in 11.5 ;-)
  4. Oli Bartsch uploaded patch set 2 V -1 03/02/23, 14:21

  5. Thomas Hohn commented on patch set 2 03/02/23, 14:25

    ImageResourceContentObject.php:18 Reply

    Done
  6. core-ci voted on patch set 2 V +1 03/02/23, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38303

  7. Oli Bartsch commented on patch set 2 V +2 CR +2 03/02/23, 14:41

    ImageResourceContentObject.php:18 Reply

    Done
  8. Oli Bartsch merged patch set 3 03/02/23, 14:42