Review main Merged

78004[TASK] Make password policy ContextData DTO more flexible

Torben Hansen CR +2 V +2 Normal +114 −40 updated 03/06/23, 09:35

Commit message

The current ContextData DTO contains a fixed set of
properties for usage in password policy validators.

In order to make the DTO more flexible, the class now
internally uses an array to store data as key/value pairs.
Additionally, the methods `getData()` and `setData()` have
been added, which extension authors can use in upcoming
PSR-14 events in order to enrich the object with custom
data.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Torben Hansen uploaded patch set 1 03/02/23, 13:17

  2. core-ci voted on patch set 1 V +1 03/02/23, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38300

  3. Torben Hansen marked it work in progress 03/02/23, 13:35

  4. Torben Hansen uploaded patch set 2 V +1 03/04/23, 11:04

  5. core-ci voted on patch set 2 V +1 03/04/23, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38432

  6. Torben Hansen marked it ready for review 03/04/23, 11:16

  7. Torben Hansen rebased onto patch set 3 V +1 03/05/23, 14:11

  8. core-ci voted on patch set 3 V +1 03/05/23, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38495

  9. Benni Mack voted on patch set 3 V +1 CR +1 03/06/23, 09:01

  10. Georg Ringer voted on patch set 3 V +2 CR +2 03/06/23, 09:35

  11. Georg Ringer merged patch set 4 03/06/23, 09:35