Review main Merged

78005[BUGFIX] Adjust Content-Security-Policy reports check for SVG files

Oliver Hader CR +2 V +2 Easy +29 −6 updated 05/15/23, 15:42

Commit message

Issue #93884 provided and adjusted CSP header for SVG inline styles:
| default-src 'self'; script-src 'none';
| style-src 'unsafe-inline'; object-src 'none';

For SVG files, having 'unsafe-inline' for style-src is fine, since
it only applies to the very same file and cannot include other local
or remote resources.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1926

Show 1 earlier messages
  1. Oliver Hader uploaded patch set 1 03/02/23, 13:45

  1. core-ci voted on patch set 1 V -1 03/02/23, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38302

  2. Oliver Hader uploaded patch set 2 V -1 03/02/23, 15:07

  3. core-ci voted on patch set 2 V +1 03/02/23, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38307

  4. Georg Ringer commented on patch set 2 03/03/23, 08:29

    ContentSecurityPolicyHeader.php:53

    do we need a strtolower? could be .SVG as well
  5. Guido Schmechel commented on patch set 2 03/03/23, 09:59

    Content-Security-Policy
  6. Oliver Hader commented on patch set 2 03/03/23, 13:02

    Reply

    Ack

    ContentSecurityPolicyHeader.php:53 Reply

    For a check in the install tool?
  7. Oliver Hader updated the commit message in patch set 3 V +1 03/03/23, 13:02

  8. core-ci voted on patch set 3 V +1 03/03/23, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38357

  9. Georg Ringer voted on patch set 3 V +1 CR +1 03/07/23, 11:46

  10. Oliver Hader commented on patch set 3 03/23/23, 11:06

    ContentSecurityPolicyHeader.php:53 Reply

    I think it's fine like this for the install tool (which is basically a static use case).
  11. Oliver Hader updated the commit message in patch set 4 CR +1 V +1 04/24/23, 07:03

  12. core-ci voted on patch set 4 V -1 04/24/23, 07:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41118

  13. core-ci commented on patch set 4 04/24/23, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41118

  14. Oliver Hader rebased onto patch set 5 V -1 04/24/23, 08:57

  15. Oliver Hader commented on patch set 5 04/24/23, 08:57

    No clue, why acceptance tests are suddenly failing when logging out...
  16. Oliver Hader commented on patch set 5 04/24/23, 09:06

    Reply

    Done
  17. core-ci voted on patch set 5 V +1 04/24/23, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41130

  18. Jörg Bösche voted on patch set 5 CR +1 04/28/23, 09:15

  19. Benni Mack updated the commit message in patch set 6 CR +1 V +1 05/03/23, 09:49

  20. Oliver Hader rebased onto patch set 7 05/03/23, 12:40

  21. core-ci voted on patch set 7 V +1 05/03/23, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41532

  22. Benni Mack voted on patch set 7 V +1 CR +1 05/07/23, 21:55

  23. Markus Klein voted on patch set 7 V +1 CR +1 05/15/23, 09:46

  24. Oliver Hader commented on patch set 7 V +2 CR +2 05/15/23, 15:42

    Merci à tous!
  25. Oliver Hader merged patch set 8 05/15/23, 15:42