Review main Merged

78007[TASK] Mitigate extbase crash in non TS context

Christian Kuhn CR +2 V +2 Normal +55 −1 updated 04/15/23, 18:49

Commit message

People tend to run extbase in context it is not
designed to be run in. TYPO3 v11 and before
has been forgiving in such cases and falls back
to a broken (empty) TypoScript configution.

TYPO3 v12 is more picky in this regard, and throws
an exception. With current TYPO3 v12 frontend
bootstrap, extension developers are a bit limited
in their options to solve this.

The patch adds a hack to extbase bootstrap code
to be as forgiving as TYPO3 v11 has been. However,
the case is logged as deprecated, and a comment
is added to explain the scenario and options.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1317

  1. Christian Kuhn uploaded patch set 1 03/02/23, 16:24

  2. core-ci voted on patch set 1 V +1 03/02/23, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38312

  3. Kevin Appelt commented on patch set 1 03/07/23, 20:08

    Stefan mentioned this change in relation to https://forge.typo3.org/issues/99458 Quick check shows: This does at least not fix the issue regarding the form backend module, if there is no sys_template in the database! Don't know for sure if this change should have fixed it (as the mentioned task seems unrelated) but still wanted to report.
  4. Alexander Schnitzler wrote 04/01/23, 17:16

    Removed cc Alexander Schnitzler.
  5. Christian Kuhn uploaded patch set 2 V +1 04/15/23, 16:49

  6. Oliver Klee voted on patch set 2 CR +1 04/15/23, 16:52

  7. Oliver Klee commented on patch set 2 04/15/23, 16:53

    Would it make sense to also log the problem in V11?
  8. Christian Kuhn commented on patch set 2 04/15/23, 16:56

    Reply

    nah. devs should only face the issue when upgrading to v12. that should be enough. and i'm not sure about v11 internals, i'd like to avoid cluttering v11 logs with this.
  9. core-ci voted on patch set 2 V +1 04/15/23, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40681

  10. Oliver Klee voted on patch set 2 V +1 04/15/23, 17:02

  11. Christian Kuhn uploaded patch set 3 CR +1 V +1 04/15/23, 17:03

  12. Oliver Klee commented on patch set 4 04/15/23, 17:13

    Published edit on patch set 3.
  13. Oliver Klee voted on patch set 4 V +1 CR +1 04/15/23, 17:13

  14. core-ci voted on patch set 3 V +1 04/15/23, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40687

  15. core-ci voted on patch set 4 V +1 04/15/23, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40688

  16. Stefan Bürk voted on patch set 4 V +2 CR +2 04/15/23, 18:49

  17. Stefan Bürk merged patch set 5 04/15/23, 18:49