Review main Merged

78010[TASK] Streamline logging in method TSFE->set_no_cache

Thomas Hohn CR +2 V +2 Easy +5 −9 updated 03/14/23, 14:43

Commit message

The logging in the method set_no_cache should not depend on the calling
parameter $internal. Instead it should be notice in both cases.
Since it's possible to change the general log level during development
or debugging the entries will still be visible, just not on production
systems which makes good sense.
In addition the variable $internal was renamed to $internalRequest in order to make the purpose clearer.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1724

  1. Thomas Hohn uploaded patch set 1 03/03/23, 05:35

  2. core-ci voted on patch set 1 V +1 03/03/23, 05:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38335

  3. Thomas Hohn updated the commit message in patch set 2 V +1 03/03/23, 06:33

  4. core-ci voted on patch set 2 V +1 03/03/23, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38336

  5. Thomas Hohn uploaded patch set 3 V +1 03/03/23, 07:34

  6. core-ci voted on patch set 3 V +1 03/03/23, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38340

  7. Thomas Hohn rebased onto patch set 4 V +1 03/06/23, 05:41

  8. core-ci voted on patch set 4 V +1 03/06/23, 05:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38509

  9. Benni Mack commented on patch set 4 03/06/23, 08:35

    TypoScriptFrontendController.php:2602

    $internal overrides the "disableNoCacheParameter" - no matter how the setting is set, $internal always disables the cache, which is very important for preview mechanisms.
  10. Thomas Hohn commented on patch set 4 03/06/23, 08:53

    TypoScriptFrontendController.php:2602 Reply

    So I hear you say that we need that $internal variable? - but can we agree on the logging part?
  11. Benni Mack commented on patch set 4 03/06/23, 08:53

    TypoScriptFrontendController.php:2602 Reply

    at least this is my understanding of the code, yes.
  12. Thomas Hohn commented on patch set 4 03/06/23, 09:34

    TypoScriptFrontendController.php:2602 Reply

    Hi - will adapt and drop my PR of getting rid of the variable - albeit the naming and comment is a bit stupid - since I found this place in the core code, which doesn't call it with true if ($pageArguments->getArguments()['no_cache'] ?? $request->getParsedBody()['no_cache'] ?? false) { $controller->set_no_cache('&no_cache=1 has been supplied, so caching is disabled! URL: "' . (string)$request->getUri() . '"'); }
  13. Benni Mack commented on patch set 4 03/06/23, 09:36

    TypoScriptFrontendController.php:2602 Reply

    that's the point.... if I call your website www.thomas-hohn.com/about/?no_cache=1 -> this is not an internal call to the method.
  14. Thomas Hohn commented on patch set 4 03/06/23, 09:38

    TypoScriptFrontendController.php:2602 Reply

    Ack
  15. Thomas Hohn uploaded patch set 5 V +1 03/06/23, 09:42

  16. core-ci voted on patch set 5 V +1 03/06/23, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38526

  17. Thomas Hohn uploaded patch set 6 V +1 03/06/23, 10:07

  18. Thomas Hohn updated the commit message in patch set 7 03/06/23, 10:10

  19. core-ci voted on patch set 7 V +1 03/06/23, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38534

  20. core-ci voted on patch set 6 V +1 03/06/23, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38533

  21. Benni Mack voted on patch set 7 V +1 CR +1 03/06/23, 13:03

  22. Jörg Bösche voted on patch set 7 CR +1 03/10/23, 07:45

  23. Christian Kuhn voted on patch set 7 V +2 CR +2 03/14/23, 14:43

  24. Christian Kuhn merged patch set 8 03/14/23, 14:43