78010[TASK] Streamline logging in method TSFE->set_no_cache
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jörg Bösche +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1724
-
Thomas Hohn uploaded patch set 1 03/03/23, 05:35
-
core-ci voted on patch set 1 V +1 03/03/23, 05:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38335
-
Thomas Hohn updated the commit message in patch set 2
V +103/03/23, 06:33 -
core-ci voted on patch set 2 V +1 03/03/23, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38336
-
Thomas Hohn uploaded patch set 3
V +103/03/23, 07:34 -
core-ci voted on patch set 3 V +1 03/03/23, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38340
-
Thomas Hohn rebased onto patch set 4
V +103/06/23, 05:41 -
core-ci voted on patch set 4 V +1 03/06/23, 05:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38509
-
Benni Mack commented on patch set 4 03/06/23, 08:35
-
Thomas Hohn commented on patch set 4 03/06/23, 08:53
TypoScriptFrontendController.php:2602ReplySo I hear you say that we need that $internal variable? - but can we agree on the logging part? -
Benni Mack commented on patch set 4 03/06/23, 08:53
TypoScriptFrontendController.php:2602Replyat least this is my understanding of the code, yes. -
Thomas Hohn commented on patch set 4 03/06/23, 09:34
TypoScriptFrontendController.php:2602ReplyHi - will adapt and drop my PR of getting rid of the variable - albeit the naming and comment is a bit stupid - since I found this place in the core code, which doesn't call it with true if ($pageArguments->getArguments()['no_cache'] ?? $request->getParsedBody()['no_cache'] ?? false) { $controller->set_no_cache('&no_cache=1 has been supplied, so caching is disabled! URL: "' . (string)$request->getUri() . '"'); } -
Benni Mack commented on patch set 4 03/06/23, 09:36
TypoScriptFrontendController.php:2602Replythat's the point.... if I call your website www.thomas-hohn.com/about/?no_cache=1 -> this is not an internal call to the method. -
Thomas Hohn commented on patch set 4 03/06/23, 09:38
TypoScriptFrontendController.php:2602ReplyAck -
Thomas Hohn uploaded patch set 5
V +103/06/23, 09:42 -
core-ci voted on patch set 5 V +1 03/06/23, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38526
-
Thomas Hohn uploaded patch set 6
V +103/06/23, 10:07 -
Thomas Hohn updated the commit message in patch set 7 03/06/23, 10:10
-
core-ci voted on patch set 7 V +1 03/06/23, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38534
-
core-ci voted on patch set 6 V +1 03/06/23, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38533
-
Benni Mack voted on patch set 7 V +1 CR +1 03/06/23, 13:03
-
Jörg Bösche voted on patch set 7 CR +1 03/10/23, 07:45
-
Christian Kuhn voted on patch set 7 V +2 CR +2 03/14/23, 14:43
-
Christian Kuhn merged patch set 8 03/14/23, 14:43
TypoScriptFrontendController.php:2602