78011[TASK] Deprecate the internal parameter for TSFE->set_no_cache
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 3
Review log 1015
-
Thomas Hohn uploaded patch set 1 03/03/23, 07:54
-
core-ci voted on patch set 1 V -1 03/03/23, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38343
-
Thomas Hohn uploaded patch set 2
V -103/03/23, 09:01 -
core-ci voted on patch set 2 V +1 03/03/23, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38347
-
Oliver Klee commented on patch set 2 03/03/23, 09:27
-
Thomas Hohn commented on patch set 2 03/03/23, 09:33
TypoScriptFrontendController.php:2583ReplyI think the correct ways it only to trigger the deprecation for $internal = false and then remove the parameter in core in TYPO3 13 - I believe thats the proper solution for now. -
Thomas Hohn uploaded patch set 3
V +103/03/23, 09:46 -
core-ci voted on patch set 3 V +1 03/03/23, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38348
-
Thomas Hohn rebased onto patch set 4
V +103/05/23, 13:31 -
core-ci voted on patch set 4 V +1 03/05/23, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38493
-
Sybille Peters commented on patch set 4 03/05/23, 17:38
minor typo: TSFC => TSFE -
Oliver Klee updated the commit message in patch set 5
V +103/05/23, 18:37 -
Oliver Klee commented on patch set 5 03/05/23, 18:37
Reply
Done -
core-ci voted on patch set 5 V +1 03/05/23, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38500
-
Thomas Hohn abandoned the change 03/06/23, 10:08
The variable is indeed needed - but has been renamed for clarity
TypoScriptFrontendController.php:2583