Review main Abandoned

78011[TASK] Deprecate the internal parameter for TSFE->set_no_cache

Thomas Hohn CR 0 V 0 Easy +46 −2 updated 03/06/23, 10:08

Commit message

Deprecate the internal parameter for the method set_no_cache in
TypoScriptFrontendController. With the issue #100067 the need
for the parameter was removed.
Calls in TYPO3 core with the parameter internal were left intact
and must be removed in TYPO3 13.0.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 3

Review log 1015

  1. Thomas Hohn uploaded patch set 1 03/03/23, 07:54

  2. core-ci voted on patch set 1 V -1 03/03/23, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38343

  3. Thomas Hohn uploaded patch set 2 V -1 03/03/23, 09:01

  4. core-ci voted on patch set 2 V +1 03/03/23, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38347

  5. Oliver Klee commented on patch set 2 03/03/23, 09:27

    TypoScriptFrontendController.php:2583

    Taking a wild shot: If there are tests that test with this parameter set explicitly, we'll either need to modify them to not use the parameter, or we'll need to move them to the unit tests for deprecated code.
  6. Thomas Hohn commented on patch set 2 03/03/23, 09:33

    TypoScriptFrontendController.php:2583 Reply

    I think the correct ways it only to trigger the deprecation for $internal = false and then remove the parameter in core in TYPO3 13 - I believe thats the proper solution for now.
  7. Thomas Hohn uploaded patch set 3 V +1 03/03/23, 09:46

  8. core-ci voted on patch set 3 V +1 03/03/23, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38348

  9. Thomas Hohn rebased onto patch set 4 V +1 03/05/23, 13:31

  10. core-ci voted on patch set 4 V +1 03/05/23, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38493

  11. Sybille Peters commented on patch set 4 03/05/23, 17:38

    minor typo: TSFC => TSFE
  12. Oliver Klee updated the commit message in patch set 5 V +1 03/05/23, 18:37

  13. Oliver Klee commented on patch set 5 03/05/23, 18:37

    Reply

    Done
  14. core-ci voted on patch set 5 V +1 03/05/23, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38500

  15. Thomas Hohn abandoned the change 03/06/23, 10:08

    The variable is indeed needed - but has been renamed for clarity