78012[TASK] Streamline ObjectMonitoring- and DomainObjectInterface usage
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 11
- Build/phpstan/phpstan-baseline.neon+0 −30
- typo3/sysext/extbase/Classes/DomainObject/AbstractDomainObject.php13+7 −7
- typo3/sysext/extbase/Classes/DomainObject/DomainObjectInterface.php3+10 −7
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+4 −4
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+0 −5
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+2 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+1 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyLoadingProxy.php+2 −3
- typo3/sysext/extbase/Classes/Persistence/ObjectMonitoringInterface.php6+7 −3
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php6+5 −3
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php+2 −3
Review log 1417
-
Alexander Schnitzler uploaded patch set 1 03/03/23, 07:59
-
Alexander Schnitzler marked it work in progress 03/03/23, 08:00
-
Alexander Schnitzler wrote 03/03/23, 08:02
Topic set to extbase -
core-ci voted on patch set 1 V +1 03/03/23, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38344
-
Alexander Schnitzler commented on patch set 1 03/03/23, 08:25
This change is ready for review. -
Oliver Klee commented on patch set 1 03/04/23, 13:13
I really love this cleanup! Thanks for doing this! I've added some comments concerning tightening the types a bit more.AbstractDomainObject.php:156`@param non-empty-string`AbstractDomainObject.php:179`@param non-empty-string|null` … and use `string|null` as native type declarationAbstractDomainObject.php:253`@param non-empty-string|null` … and use `string|null` as native type declarationDomainObjectInterface.php:58`@param non-empty-string`ObjectMonitoringInterface.php:32`@param non-empty-string|null` … and use `string|null` as native type declarationObjectMonitoringInterface.php:37`@param non-empty-string|null` … and use `string|null` as native type declarationObjectStorage.php:335`@param non-empty-string|null` … and use `string|null` as native type declarationObjectStorage.php:343`@param non-empty-string|null` … and use `string|null` as native type declaration -
Stefan Froemken commented on patch set 1 V +1 CR +1 03/06/23, 18:18
AbstractDomainObject.php:179Replynon-empty-string is OK, but if a property name is given, is is and should never be null. So just string is OK for me. Do not allow nullable property name here.AbstractDomainObject.php:253ReplySee my comment above -
Alexander Schnitzler commented on patch set 1 03/07/23, 09:53
AbstractDomainObject.php:179ReplyNo, Oli is right here. The `$propertyName` is only used on `ObjectStorage::_memorizeCleanState()`. On `AbstractDomainObject`s, we want to memorize the state of all properties. The interface cannot be too strict because of the implementation. Unfortunate but the better of two bad options.AbstractDomainObject.php:253Replydito -
Alexander Schnitzler uploaded patch set 2
CR +1V +103/07/23, 15:42 -
Alexander Schnitzler commented on patch set 2 03/07/23, 15:44
AbstractDomainObject.php:156ReplyDoneAbstractDomainObject.php:179ReplyDoneAbstractDomainObject.php:253ReplyDoneDomainObjectInterface.php:58ReplyDoneObjectMonitoringInterface.php:32ReplyDoneObjectMonitoringInterface.php:37ReplyDoneObjectStorage.php:335ReplyDoneObjectStorage.php:343ReplyDone -
Oliver Klee commented on patch set 2 CR +1 03/07/23, 15:44
AbstractDomainObject.php:156ReplyDoneAbstractDomainObject.php:179ReplyDoneAbstractDomainObject.php:253ReplyDoneDomainObjectInterface.php:58ReplyDoneObjectMonitoringInterface.php:32ReplyDoneObjectMonitoringInterface.php:37ReplyDoneObjectStorage.php:335ReplyDoneObjectStorage.php:343ReplyDone -
Alexander Schnitzler rebased onto patch set 3
CR +103/07/23, 15:44 -
core-ci voted on patch set 3 V +1 03/07/23, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38612
-
Oliver Klee voted on patch set 3 V +1 CR +1 03/07/23, 15:58
-
core-ci voted on patch set 2 V -1 03/07/23, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38611
-
Benni Mack voted on patch set 3 V +2 CR +2 03/07/23, 17:25
-
Benni Mack merged patch set 4 03/07/23, 17:25