Review main Merged

78022[BUGFIX] Avoid invalid array access on $this->internal in AbstractPlugin

Oliver Klee CR +2 V +2 Easy +12 −12 updated 03/08/23, 07:50

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Oliver Klee uploaded patch set 1 03/04/23, 09:53

  2. core-ci voted on patch set 1 V +1 03/04/23, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38428

  3. Benni Mack voted on patch set 1 CR +1 03/06/23, 09:04

  4. Thomas Hohn voted on patch set 1 CR +1 03/06/23, 09:34

  5. Alexander Schnitzler commented on patch set 1 03/06/23, 10:06

    AbstractPlugin.php:663

    Just one thought here: I shortly searched for writable access to `$this->internal['dontLinkActivePage']` and didn't find any. So beyond the problem that this array key is not initialized, it's not even guaranteed that `$this->internal['dontLinkActivePage']` is a bool. Don't get me wrong. This current approach (as bugfix) is great. But I would love to see a follow-up, introducing an object for `$this->internal`.
  6. Alexander Schnitzler commented on patch set 1 V +1 CR -1 03/06/23, 10:12

    AbstractPlugin.php:702

    I think there is a whitespace missing before `>` now.

    AbstractPlugin.php:705

    Dito
  7. Alexander Schnitzler uploaded patch set 2 CR +1 V +1 03/06/23, 10:33

  8. Alexander Schnitzler commented on patch set 2 V +1 CR +1 03/06/23, 10:34

    AbstractPlugin.php:702 Reply

    Done

    AbstractPlugin.php:705 Reply

    Done
  9. Oliver Klee commented on patch set 2 03/06/23, 10:35

    Thanks, Alexander!
  10. Oliver Klee rebased onto patch set 3 CR +1 V +1 03/06/23, 10:56

  11. core-ci voted on patch set 2 V -1 03/06/23, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38538

  12. core-ci voted on patch set 3 V +1 03/06/23, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38546

  13. Alexander Schnitzler voted on patch set 3 V +1 CR +1 03/06/23, 11:17

  14. Benni Mack voted on patch set 3 V +2 CR +2 03/08/23, 07:50

  15. Benni Mack merged patch set 4 03/08/23, 07:50