Review main Merged

78023[BUGFIX] Show correct alt Text in SystemEmail

Sybille Peters CR +2 V +2 Easy +1 −1 updated 03/14/23, 13:48

Commit message

Use alt text "Logo" (instead of "TYPO3 Logo") in the SystemEmail
Fluid layout if a custom logo is used.

The layout SystemEmail is used by default when sending Fluid emails.
It is for example used when sending a test email via the "Environment"
module in the install tool or "Admin Tools" in the backend.

If an image is configured in the backend Extension Configuration
login.loginLogo, this image is used and the text is added as alt
text.

Previously, "TYPO3 Logo" was always used as alt text, which is awkward
if the alt text is displayed instead of the logo, which may happen for
several reasons

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1519

  1. Sybille Peters uploaded patch set 1 03/04/23, 10:43

  2. core-ci voted on patch set 1 V +1 03/04/23, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38430

  3. Oliver Klee voted on patch set 1 CR +1 03/04/23, 10:51

  4. Sybille Peters commented on patch set 1 CR -1 03/04/23, 10:53

  5. Torben Hansen updated the commit message in patch set 2 CR +1 V +1 03/04/23, 10:54

  6. Torben Hansen voted on patch set 2 V +1 CR +1 03/04/23, 10:55

  7. Sybille Peters commented on patch set 1 CR 0 03/04/23, 10:56

    Reply

    However, the other patch is a feature request and will not be backported to v11.5, so this patch is probably still valid.
  8. core-ci voted on patch set 2 V +1 03/04/23, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38431

  9. Oliver Klee voted on patch set 2 V +1 CR +1 03/04/23, 11:04

  10. Sybille Peters updated the commit message in patch set 3 CR +1 V +1 03/04/23, 11:06

  11. core-ci voted on patch set 3 V +1 03/04/23, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38433

  12. Oliver Klee voted on patch set 3 CR +1 03/04/23, 11:15

  13. Oliver Klee voted on patch set 3 V +1 03/04/23, 11:15

  14. Sybille Peters rebased onto patch set 4 CR +1 V +1 03/05/23, 16:03

  15. core-ci voted on patch set 4 V +1 03/05/23, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38499

  16. Oliver Klee voted on patch set 4 V +1 CR +1 03/05/23, 18:38

  17. Torben Hansen voted on patch set 4 V +1 CR +1 03/05/23, 18:43

  18. Christian Kuhn voted on patch set 4 V +2 CR +2 03/14/23, 13:48

  19. Christian Kuhn merged patch set 5 03/14/23, 13:48