78029[FEATURE] Introduce Doctrine DBAL v3 driver middlewares
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/adminpanel/Classes/Log/DoctrineSqlLogger.php+18 −12
- typo3/sysext/adminpanel/Classes/Log/DoctrineSqlLoggingMiddleware.phpnew+48 −0
- typo3/sysext/adminpanel/Classes/Log/LoggingConnection.phpnew+63 −0
- typo3/sysext/adminpanel/Classes/Log/LoggingDriver.php7new+43 −0
- typo3/sysext/adminpanel/Classes/Log/LoggingStatement.phpnew+61 −0
- typo3/sysext/adminpanel/Classes/Middleware/SqlLogging.php+7 −3
- typo3/sysext/adminpanel/Classes/Modules/Debug/QueryInformation.php+12 −4
- typo3/sysext/adminpanel/ext_localconf.php+6 −0
- typo3/sysext/core/Classes/Database/ConnectionPool.php+25 −1
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-100089-IntroduceDoctrineDBALv3drivermiddlewares.rstnew+38 −0
Review log 2230
Show 45 earlier messages
-
Christian Eßl uploaded patch set 1 03/04/23, 20:24
-
Christian Eßl updated the commit message in patch set 2 03/04/23, 20:25
-
Christian Eßl abandoned the change 03/04/23, 20:26
oops, wrong id -
Christian Eßl restored the change 03/04/23, 20:26
-
core-ci voted on patch set 2 V -1 03/04/23, 21:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38456
-
core-ci voted on patch set 1 V -1 03/04/23, 21:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38455
-
Stefan Bürk rebased onto patch set 3
V -103/05/23, 02:19 -
core-ci voted on patch set 3 V -1 03/05/23, 02:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38473
-
Simon Schaufelberger commented on patch set 3 CR -1 03/05/23, 03:28
LoggingDriver.php:37does not follow code style "{ should be on new line"LoggingDriver.php:44does not follow code style "{ should be on new line" -
Stefan Bürk commented on patch set 3 03/05/23, 03:29
LoggingDriver.php:44Reply`Build\Scripts\runTests.sh -s cglGit` should do the trick (with patch locally) -
Christian Eßl commented on patch set 3 03/05/23, 06:53
LoggingDriver.php:44ReplyWeird, I executed the code fixer yesterday... will try it out again. 😊 -
Christian Eßl uploaded patch set 4
CR -1V -103/05/23, 07:26 -
Chris Müller rebased onto patch set 5 03/05/23, 07:52
-
Chris Müller uploaded patch set 6 03/05/23, 07:52
-
core-ci voted on patch set 6 V +1 03/05/23, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38480
-
core-ci voted on patch set 4 V -1 03/05/23, 08:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38478
-
core-ci voted on patch set 5 V +1 03/05/23, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38479
-
Stefan Bürk commented on patch set 6 03/05/23, 18:05
LoggingDriver.php:44Reply^that command only scan files committed in the last commit. If you used that command with unstaged changes it may have missed something. Using the hook will execute that as pre-commit. The message will be only visible on cli, as most GUI's will not display the output with exit code 0. Beside this, the pipeline is telling you this, that the cgl is not correct. -
Stefan Bürk commented on patch set 6 03/05/23, 18:07
LoggingDriver.php:37ReplyDoneLoggingDriver.php:44ReplyDone -
Stefan Bürk commented on patch set 6 CR -1 03/06/23, 08:37
I had a first quick look, and so far it looks fine. I have to check some other things (regarding doctrine/dbal 4) when I have more time, thus the temp -1 for now. -
Christian Eßl rebased onto patch set 7
CR -1V +103/07/23, 13:11 -
core-ci voted on patch set 7 V +1 03/07/23, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38597
-
Stefan Bürk commented on patch set 7 CR -1 03/07/23, 13:42
Reply
did not found the time to eloborate on that, thus temp -1 again -
Oliver Klee commented on patch set 7 03/10/23, 16:05
Can we mark any of the new classes/methods as `@internal` so we can refactor/remove them later at will? -
Christian Eßl uploaded patch set 8
CR -1V +103/13/23, 07:46 -
core-ci voted on patch set 8 V +1 03/13/23, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38856
-
Benni Mack voted on patch set 8 CR +1 03/15/23, 21:40
-
Stefan Bürk commented on patch set 8 V +1 CR +1 03/15/23, 22:12
This should be fine. Took some time, so take my excuse. But had to check some things to get rid of some bad feelings (which turned out to be wrong). -
Benni Mack commented on patch set 8 V +2 CR +2 03/15/23, 22:21
also tested it quickly, and it's a necessary step towards Doctrine DBAL 4. -
Benni Mack merged patch set 9 03/15/23, 22:21