78030[TASK] Cleanup middlewares
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php+1 −3
- typo3/sysext/backend/Classes/Middleware/LockedBackendGuard.php+1 −2
- typo3/sysext/backend/Classes/Middleware/OutputCompression.php+1 −1
- typo3/sysext/core/Classes/Middleware/BackendUserAuthenticator.php+1 −7
- typo3/sysext/frontend/Classes/Middleware/BackendUserAuthenticator.php7+5 −12
- typo3/sysext/frontend/Classes/Middleware/EidHandler.php+0 −3
- typo3/sysext/frontend/Classes/Middleware/FrontendUserAuthenticator.php+4 −10
- typo3/sysext/frontend/Classes/Middleware/OutputCompression.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php+3 −17
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php+1 −4
- typo3/sysext/frontend/Classes/Middleware/SiteBaseRedirectResolver.php+1 −3
- typo3/sysext/frontend/Classes/Middleware/SiteResolver.php+1 −7
- typo3/sysext/frontend/Classes/Middleware/StaticRouteResolver.php+3 −18
- typo3/sysext/frontend/Classes/Middleware/TimeTrackerInitialization.php+1 −7
Review log 1215
-
Torben Hansen uploaded patch set 1 03/05/23, 11:53
-
core-ci voted on patch set 1 V -1 03/05/23, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38488
-
Torben Hansen rebased onto patch set 2
V -103/05/23, 12:39 -
core-ci voted on patch set 2 V +1 03/05/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38490
-
Benni Mack voted on patch set 2 V +1 CR +1 03/06/23, 08:57
-
Oliver Klee commented on patch set 2 03/06/23, 09:09
BackendUserAuthenticator.php:44Why the change from private to protected? -
Benni Mack commented on patch set 2 03/06/23, 15:15
BackendUserAuthenticator.php:43Replyboth variants work fineBackendUserAuthenticator.php:44ReplyThis is a prepatch for more authentication part cleanup, in general both context + languageservicefactory should go into the parent class in a later patch -
Oliver Klee commented on patch set 2 03/06/23, 15:17
BackendUserAuthenticator.php:43ReplyThen please let's drop the constructor promotion of $context here. This makes the code less confusing.BackendUserAuthenticator.php:44ReplyAck -
Nikita Hovratov uploaded patch set 3
CR +1V +103/06/23, 17:10 -
Nikita Hovratov commented on patch set 3 V +1 CR +1 03/06/23, 17:11
BackendUserAuthenticator.php:43ReplyDone -
Oliver Klee voted on patch set 3 CR +1 03/06/23, 17:15
-
Oliver Klee commented on patch set 3 03/06/23, 17:15
Thanks! -
core-ci voted on patch set 3 V +1 03/06/23, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38559
-
Benni Mack voted on patch set 3 V +2 CR +2 03/07/23, 10:47
-
Benni Mack merged patch set 4 03/07/23, 10:47
BackendUserAuthenticator.php:43