Review main Merged

78030[TASK] Cleanup middlewares

Torben Hansen CR +2 V +2 Normal +24 −95 updated 03/07/23, 10:47

Commit message

This change cleans up middlewares by

* using constructor property promotion where possible
* strict types where possible
* Remove `@throws` annotations for exceptions never thrown
* Remove value in function call, if it equals the default

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1215

  1. Torben Hansen uploaded patch set 1 03/05/23, 11:53

  2. core-ci voted on patch set 1 V -1 03/05/23, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38488

  3. Torben Hansen rebased onto patch set 2 V -1 03/05/23, 12:39

  4. core-ci voted on patch set 2 V +1 03/05/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38490

  5. Benni Mack voted on patch set 2 V +1 CR +1 03/06/23, 08:57

  6. Oliver Klee commented on patch set 2 03/06/23, 09:09

    BackendUserAuthenticator.php:43

    $context should stay a common parameter as it only gets passed to the parent constructor. Or am I missing something here?

    BackendUserAuthenticator.php:44

    Why the change from private to protected?
  7. Benni Mack commented on patch set 2 03/06/23, 15:15

    BackendUserAuthenticator.php:43 Reply

    both variants work fine

    BackendUserAuthenticator.php:44 Reply

    This is a prepatch for more authentication part cleanup, in general both context + languageservicefactory should go into the parent class in a later patch
  8. Oliver Klee commented on patch set 2 03/06/23, 15:17

    BackendUserAuthenticator.php:43 Reply

    Then please let's drop the constructor promotion of $context here. This makes the code less confusing.

    BackendUserAuthenticator.php:44 Reply

    Ack
  9. Nikita Hovratov uploaded patch set 3 CR +1 V +1 03/06/23, 17:10

  10. Nikita Hovratov commented on patch set 3 V +1 CR +1 03/06/23, 17:11

    BackendUserAuthenticator.php:43 Reply

    Done
  11. Oliver Klee voted on patch set 3 CR +1 03/06/23, 17:15

  12. Oliver Klee commented on patch set 3 03/06/23, 17:15

    Thanks!
  13. core-ci voted on patch set 3 V +1 03/06/23, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38559

  14. Benni Mack voted on patch set 3 V +2 CR +2 03/07/23, 10:47

  15. Benni Mack merged patch set 4 03/07/23, 10:47