Review main Merged

78034[TASK] Refactor GU::getFileAbsFileName

Nikita Hovratov CR +2 V +2 Easy +22 −19 updated 03/08/23, 08:12

Commit message

Improve readability of the method by extracting distinct cases into own
blocks with early return statements.

Case 1: "EXT:" path
Case 2: (already) absolute path
Case 3: relative public path

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 711

  1. Nikita Hovratov uploaded patch set 1 03/06/23, 08:42

  2. Benni Mack voted on patch set 1 CR +1 03/06/23, 08:55

  3. core-ci voted on patch set 1 V -1 03/06/23, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38519

  4. core-ci commented on patch set 1 03/06/23, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38519

  5. Nikita Hovratov rebased onto patch set 2 CR +1 V -1 03/06/23, 09:55

  6. core-ci voted on patch set 2 V -1 03/06/23, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38532

  7. Nikita Hovratov uploaded patch set 3 V -1 03/06/23, 10:39

  8. core-ci voted on patch set 3 V +1 03/06/23, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38540

  9. Benni Mack voted on patch set 3 V +1 CR +1 03/08/23, 08:10

  10. Georg Ringer voted on patch set 3 V +2 CR +2 03/08/23, 08:12

  11. Georg Ringer merged patch set 4 03/08/23, 08:12