Review main Abandoned

78037[FEATURE] Introduce cache aware PropertyAccessor instances

Alexander Schnitzler CR 0 V 0 Hard +629 −2 updated 04/01/23, 17:14

Commit message

A while back, extbase added a dependency to symfony/property-access,
to replace the internal logic of ObjectAccess while leaving the object
itself intact as proxy api.

symfony/property-access, just like ObjectAccess prior to it, uses
reflection classes to gather information on how to set property
values. Reflection can have quite an impact on the performance,
therefore it makes sense to cache the information gathered via
reflection. symfony/property-access optionally support a PSR-6
compatible cache item pool, we do make use of as of this patch.

At this moment, only extbase uses the property accessor but to
make it available for future use in other core parts, the cache
and factory implementations have been moved to ext:core.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 11

Review log 913

  1. Alexander Schnitzler uploaded patch set 1 03/06/23, 16:22

  2. Alexander Schnitzler marked it work in progress 03/06/23, 16:23

  3. core-ci voted on patch set 1 V -1 03/06/23, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38553

  4. Alexander Schnitzler uploaded patch set 2 V -1 03/07/23, 10:36

  5. core-ci voted on patch set 2 V -1 03/07/23, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38590

  6. Alexander Schnitzler uploaded patch set 3 V -1 03/07/23, 13:39

  7. Alexander Schnitzler marked it ready for review 03/07/23, 13:39

  8. core-ci voted on patch set 3 V -1 03/07/23, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38605

  9. Benni Mack commented on patch set 3 03/07/23, 14:49

    by the way, we could just use symfony/cache for that now, instead of building our own PSR-6 implementation. I know that Lolli wanted to check this as well.
  10. Alexander Schnitzler uploaded patch set 4 V -1 03/07/23, 15:29

  11. Alexander Schnitzler commented on patch set 4 03/07/23, 15:31

    Reply Unresolved

    Yep, I know there are solutions but I didn't know the current state of PSR-6 and our own caching framework and I just thought, that with PSR-6, it's super easy to merge a working self-made solution and replace it in the future. I have absolutely no hard feelings regarding this implementation.
  12. core-ci voted on patch set 4 V +1 03/07/23, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38610

  13. Alexander Schnitzler abandoned the change 04/01/23, 17:14