78037[FEATURE] Introduce cache aware PropertyAccessor instances
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 11
- typo3/sysext/core/Classes/PropertyAccess/Cache/CacheItem.phpnew+65 −0
- typo3/sysext/core/Classes/PropertyAccess/Cache/CacheItemPool.phpnew+154 −0
- typo3/sysext/core/Classes/PropertyAccess/Cache/InvalidArgumentException.phpnew+22 −0
- typo3/sysext/core/Classes/PropertyAccess/PropertyAccessorBuilderFactory.phpnew+36 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+8 −0
- typo3/sysext/core/Configuration/Services.yaml+15 −0
- typo3/sysext/core/Tests/Functional/PropertyAccess/Cache/CacheItemPoolTest.phpnew+130 −0
- typo3/sysext/core/Tests/Unit/PropertyAccess/Cache/CacheItemPoolTest.phpnew+103 −0
- typo3/sysext/core/Tests/Unit/PropertyAccess/Cache/CacheItemTest.phpnew+93 −0
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/extbase/Classes/Reflection/ObjectAccess.php+2 −2
Review log 913
-
Alexander Schnitzler uploaded patch set 1 03/06/23, 16:22
-
Alexander Schnitzler marked it work in progress 03/06/23, 16:23
-
core-ci voted on patch set 1 V -1 03/06/23, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38553
-
Alexander Schnitzler uploaded patch set 2
V -103/07/23, 10:36 -
core-ci voted on patch set 2 V -1 03/07/23, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38590
-
Alexander Schnitzler uploaded patch set 3
V -103/07/23, 13:39 -
Alexander Schnitzler marked it ready for review 03/07/23, 13:39
-
core-ci voted on patch set 3 V -1 03/07/23, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38605
-
Benni Mack commented on patch set 3 03/07/23, 14:49
by the way, we could just use symfony/cache for that now, instead of building our own PSR-6 implementation. I know that Lolli wanted to check this as well. -
Alexander Schnitzler uploaded patch set 4
V -103/07/23, 15:29 -
Alexander Schnitzler commented on patch set 4 03/07/23, 15:31
Reply Unresolved
Yep, I know there are solutions but I didn't know the current state of PSR-6 and our own caching framework and I just thought, that with PSR-6, it's super easy to merge a working self-made solution and replace it in the future. I have absolutely no hard feelings regarding this implementation. -
core-ci voted on patch set 4 V +1 03/07/23, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38610
-
Alexander Schnitzler abandoned the change 04/01/23, 17:14