Review main Merged

78038[TASK] Build submodules from scheduler module parts

Benni Mack CR +2 V +2 Hard +324 −214 updated 03/07/23, 10:46

Commit message

This change splits up
* Edit/List/Add view of Scheduler
* Check Setup
* Available Tasks

in each a separate controller + a custom third-level
module.

This way, it is then possible to separate the
main scheduler module into custom actions (via subroutes)
making the code a tiny bit more manageable.

The previous "system_txschedulerM1" module name is now
aliased to "scheduler_manage" (third-level), as the main
scheduler module is now solely called "scheduler". The old
name is kept for backwards-compatibility reasons.

A note for historical fans: "M1" stands for "module 1" within
the "tx_scheduler" extension.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1118

  1. Benni Mack uploaded patch set 1 03/06/23, 16:33

  2. Benni Mack uploaded patch set 2 03/06/23, 16:33

  3. core-ci voted on patch set 1 V -1 03/06/23, 16:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38554

  4. core-ci voted on patch set 2 V -1 03/06/23, 17:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38555

  5. Jochen Roth uploaded patch set 3 V -1 03/06/23, 20:51

  6. core-ci voted on patch set 3 V -1 03/06/23, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38566

  7. Jochen Roth uploaded patch set 4 V -1 03/06/23, 22:17

  8. core-ci voted on patch set 4 V +1 03/06/23, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38567

  9. Benni Mack uploaded patch set 5 V +1 03/07/23, 08:18

  10. Benni Mack commented on patch set 6 03/07/23, 08:20

    Published edit on patch set 5.
  11. core-ci voted on patch set 5 V +1 03/07/23, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38581

  12. core-ci voted on patch set 6 V +1 03/07/23, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38582

  13. Stefan Bürk updated the commit message in patch set 7 V +1 03/07/23, 09:41

  14. core-ci voted on patch set 7 V +1 03/07/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38585

  15. Stefan Bürk voted on patch set 7 V +1 CR +1 03/07/23, 10:06

  16. Jochen Roth voted on patch set 7 V +1 CR +1 03/07/23, 10:45

  17. Benni Mack voted on patch set 7 V +2 CR +2 03/07/23, 10:45

  18. Benni Mack merged patch set 8 03/07/23, 10:46