Review main Merged

78040[TASK] Cleanup eslint configuration

Benjamin Kott CR +2 V +2 Nightmare +2892 −2912 updated 03/09/23, 11:27

Commit message

We renamed the eslint configuration to follow the recommended standards
so developers IDEs will pick up the configuration more easily.

The ruleset was adapted to follow a wider range of recommendations.
- eslint:recommended
- @typescript-eslint/recommended
- lit/recommended
- wc/recommended

In addition we now also force more kinds of spacing rules to avoid
IDEs having different opinions on how to format for example includes.

The only recommendation we don't want to follow is
- @typescript-eslint/no-inferrable-types.
We don't want to disallow being explicit.

Instead of turning off rules we cannot fully fulfill as of now, we are
now changing the configuration to warning. This will help developers
spotting mistakes more easy when writing code.

Rules that are currently in "warn" mode:
- @typescript-eslint/ban-types
- @typescript-eslint/no-explicit-any
- @typescript-eslint/no-this-alias

To only check for errors run in the Build directory:
- npx eslint ./Sources/TypeScript/ --quiet

We are removing the custom member ordering and preferring the default.
@typescript-eslint/member-ordering

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 399

Show 379 more files

Review log 2236

Show 611 earlier messages
  1. Benjamin Kott uploaded patch set 1 03/06/23, 16:54

  2. core-ci voted on patch set 1 V +1 03/06/23, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38557

  3. Benjamin Kott uploaded patch set 2 V +1 03/07/23, 10:30

  4. core-ci voted on patch set 2 V -1 03/07/23, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38587

  5. Andreas Kienast uploaded patch set 3 V -1 03/07/23, 12:57

  6. core-ci voted on patch set 3 V -1 03/07/23, 13:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38596

  7. Andreas Kienast uploaded patch set 4 V -1 03/07/23, 16:08

  8. Andreas Kienast commented on patch set 4 V -1 03/07/23, 16:11

    Currently at least the file conflict dialog in the filelist is broken.
  9. core-ci voted on patch set 4 V -1 03/07/23, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38614

  10. Benjamin Kott uploaded patch set 5 V -1 03/07/23, 17:44

  11. core-ci voted on patch set 5 V -1 03/07/23, 18:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38621

  1. Benjamin Kott uploaded patch set 6 V -1 03/08/23, 08:00

  2. core-ci voted on patch set 6 V -1 03/08/23, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38642

  3. Benjamin Kott uploaded patch set 7 V -1 03/08/23, 16:19

  4. core-ci voted on patch set 7 V -1 03/08/23, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38660

  5. Benjamin Kott uploaded patch set 8 V -1 03/08/23, 17:17

  6. core-ci voted on patch set 8 V +1 03/08/23, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38662

  7. Benjamin Kott uploaded patch set 9 V +1 03/08/23, 17:43

  8. core-ci voted on patch set 9 V -1 03/08/23, 18:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38664

  9. Oliver Hader commented on patch set 9 03/08/23, 18:50

    drag-uploader.ts:215

    Interesting... will test explicitly

    drag-uploader.ts:719

    (later) remove debug output

    editable-page-title.ts:189

    Record?

    folder-structure.ts:117

    Drive-by bugfix, using `append` instead of `html`?

    image-processing.ts:79

    Drive-by?

    mail-test.ts:72

    Drive-by?
  10. Andreas Kienast commented on patch set 9 03/08/23, 18:52

    folder-structure.ts:117 Reply

    nope. jQuery itself handles jQuery-objects passed to `html()`, but it‘s not declared as such in TypeScript.
  11. Benjamin Kott uploaded patch set 10 V -1 03/09/23, 07:27

  12. core-ci voted on patch set 10 V +1 03/09/23, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38674

  13. Benjamin Kott uploaded patch set 11 V +1 03/09/23, 07:42

  14. Benjamin Kott uploaded patch set 12 03/09/23, 07:43

  15. Benjamin Kott commented on patch set 10 03/09/23, 07:44

    drag-uploader.ts:215 Reply

    process files wants a filelist, that we already have, any transformations here are unessesary. this.fileInput.files: FileList public processFiles(files: FileList)

    drag-uploader.ts:719 Reply

    Ack

    editable-page-title.ts:189 Reply

    Done

    folder-structure.ts:117 Reply

    Ack

    image-processing.ts:79 Reply

    Ack

    mail-test.ts:72 Reply

    Ack
  16. core-ci voted on patch set 12 V +1 03/09/23, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38676

  17. core-ci voted on patch set 11 V -1 03/09/23, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38675

  18. Benjamin Kott uploaded patch set 13 V +1 03/09/23, 09:40

  19. core-ci voted on patch set 13 V +1 03/09/23, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38685

  20. Benni Mack updated the commit message in patch set 14 V +1 03/09/23, 10:29

  21. Benni Mack voted on patch set 14 V +1 CR +1 03/09/23, 10:30

  22. core-ci voted on patch set 14 V +1 03/09/23, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38689

  23. Oliver Hader voted on patch set 14 V +1 CR +1 03/09/23, 11:22

  24. Oliver Hader voted on patch set 14 V +2 CR +2 03/09/23, 11:26

  25. Oliver Hader merged patch set 15 03/09/23, 11:27