Review main Abandoned

78042[TASK] Improve performance of PagesXmlSitemapDataProvider

Christian Eßl CR 0 V 0 Normal +105 −71 updated 03/07/23, 08:08

Commit message

Improve the performance of the page sitemap generation by
directly using the site's router. This saves us many db
calls to RootLineUtility. Also only select fields in the
query, that are required for sitemap generation.
In case the page is a mounted page, a fallback to
$cObj->createUrl() is required.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 45

  1. Christian Eßl uploaded patch set 1 03/06/23, 20:24

  2. core-ci voted on patch set 1 V -1 03/06/23, 21:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38565

  3. Christian Eßl commented on patch set 1 V -1 CR -1 03/07/23, 07:06

    Mount points are wrongly resolved (it appears they were even wrongly resolved before. I'll check how long thas has been the case.) And I think I should handle this very differently and not change these methods in PageRepository.
  4. Stefan Bürk commented on patch set 1 03/07/23, 07:16

    Just a reminder - please rebase your patch then ;) it's working with the wrong dind image
  5. Christian Eßl abandoned the change 03/07/23, 08:08