Review main Abandoned

78049[BUGFIX] Fix type error in UnableToLinkException->getLinkText

Thomas Hohn CR 0 V 0 Easy +6 −1 updated 03/08/23, 10:00

Commit message

The type hint indicates, that $linkText should be of type string.
However this is not always the case in TYPO3 v11, it can contain
an instance of LinkResult.
The code has been refactored in TYPO3 v12 and since the
potential code has been removed from ContentObjectRenderer this
fix is to be considered temporarily.
In TYPO3 v13 the signature of the constructor should be changed
to be strict typed, and only accept string as a valid type for
$linkText.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 57

  1. Thomas Hohn uploaded patch set 1 03/07/23, 20:56

  2. Thomas Hohn updated the commit message in patch set 2 03/07/23, 21:01

  3. core-ci voted on patch set 1 V -1 03/07/23, 21:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38630

  4. core-ci voted on patch set 2 V -1 03/07/23, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38632

  5. Oliver Klee commented on patch set 2 03/07/23, 22:31

    Shouldn't this change then be 11.5-only?
    temporarily -> temporary
  6. Thomas Hohn commented on patch set 2 03/08/23, 08:06

    Reply Unresolved

    You could argue that it would make sense only to fix it in 11.5 and then create a separate issue for the type strengthening

    Reply

    Ack
  7. Thomas Hohn abandoned the change 03/08/23, 10:00

    Will create a 11.5 only branch