Review 11.5 Merged

78065[BUGFIX] Avoid PHP 8 warnings when processing the INTinclude-scripts

Benni Mack CR +2 V +2 Normal +84 −2 updated 03/22/23, 12:16

Commit message

Avoid PHP warnings when calling the method to process INTinclude
scripts when jsInline or jsFooterInline was set.

Previously, the jsInline and jsFooterInline was called after
$TSFE->INTincScript_loadJScode(), where TSFE considered
there were no *_INT objects, however, they were processed
later-on, thus no "divKey" was set and a PHP warning
was set.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Albrecht Köhnlein +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Albrecht Köhnlein +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1015

  1. Benni Mack commented on patch set 1 03/21/23, 21:17

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Http/RequestHandler.php * typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerTest.php
  2. Benni Mack commented on patch set 2 03/21/23, 21:18

    Published edit on patch set 1.
  3. Benni Mack commented on patch set 3 03/21/23, 21:20

    Published edit on patch set 2.
  4. Benni Mack commented on patch set 4 03/21/23, 21:21

    Published edit on patch set 3.
  5. Benni Mack marked it ready for review 03/21/23, 21:21

  6. core-ci voted on patch set 1 V -1 03/21/23, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39349

  7. core-ci voted on patch set 2 V -1 03/21/23, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39350

  8. core-ci voted on patch set 4 V -1 03/21/23, 21:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39352

  9. core-ci voted on patch set 3 V -1 03/21/23, 21:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39351

  10. Nikita Hovratov commented on patch set 4 03/22/23, 11:23

    on it
  11. Nikita Hovratov uploaded patch set 5 V -1 03/22/23, 11:50

  12. core-ci voted on patch set 5 V +1 03/22/23, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39379

  13. Albrecht Köhnlein commented on patch set 5 V +1 CR +1 03/22/23, 12:03

    Thank you. Works in my scenario.
  14. Nikita Hovratov voted on patch set 5 V +2 CR +2 03/22/23, 12:15

  15. Nikita Hovratov merged patch set 6 03/22/23, 12:16