78065[BUGFIX] Avoid PHP 8 warnings when processing the INTinclude-scripts
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Albrecht Köhnlein +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Albrecht Köhnlein +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+5 −2
- typo3/sysext/frontend/Tests/Functional/Controller/DataSet/LiveDefaultPages.csvnew+11 −0
- typo3/sysext/frontend/Tests/Functional/Controller/Fixtures/jsInline.typoscriptnew+10 −0
- typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerWithFrontendTest.phpnew+58 −0
Review log 1015
-
Benni Mack commented on patch set 1 03/21/23, 21:17
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Http/RequestHandler.php * typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerTest.php -
Benni Mack commented on patch set 2 03/21/23, 21:18
Published edit on patch set 1. -
Benni Mack commented on patch set 3 03/21/23, 21:20
Published edit on patch set 2. -
Benni Mack commented on patch set 4 03/21/23, 21:21
Published edit on patch set 3. -
Benni Mack marked it ready for review 03/21/23, 21:21
-
core-ci voted on patch set 1 V -1 03/21/23, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39349
-
core-ci voted on patch set 2 V -1 03/21/23, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39350
-
core-ci voted on patch set 4 V -1 03/21/23, 21:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39352
-
core-ci voted on patch set 3 V -1 03/21/23, 21:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39351
-
Nikita Hovratov commented on patch set 4 03/22/23, 11:23
on it -
Nikita Hovratov uploaded patch set 5
V -103/22/23, 11:50 -
core-ci voted on patch set 5 V +1 03/22/23, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39379
-
Albrecht Köhnlein commented on patch set 5 V +1 CR +1 03/22/23, 12:03
Thank you. Works in my scenario. -
Nikita Hovratov voted on patch set 5 V +2 CR +2 03/22/23, 12:15
-
Nikita Hovratov merged patch set 6 03/22/23, 12:16