Review main Merged

78072[TASK] Add todo for strictly typing class UnableToLinkException

Thomas Hohn CR +2 V +2 Easy +2 −0 updated 03/14/23, 13:50

Commit message

The constructor of UnableToLinkException should be strictly
typed, since the method getLinkText() is strictly typed.
Also make the variable declaration of $linkText strictly typed.
It will throw an error if $linkText isn't a string.
Added a todo for TYPO3 v13.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1216

  1. Thomas Hohn uploaded patch set 1 03/08/23, 09:05

  2. core-ci voted on patch set 1 V +1 03/08/23, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38646

  3. Benni Mack commented on patch set 1 03/08/23, 09:52

    UnableToLinkException.php:30

    we should then also mark the $linkText strictly typed :)
  4. Thomas Hohn commented on patch set 1 03/08/23, 10:40

    UnableToLinkException.php:30 Reply

    Ack
  5. Thomas Hohn uploaded patch set 2 V +1 03/08/23, 10:42

  6. core-ci voted on patch set 2 V +1 03/08/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38650

  7. Oliver Klee commented on patch set 2 03/08/23, 11:58

    The subject now is misleading, as it implies that this change adds the strict typing (which it doesn't). My suggestion: [TASK] Add todo for strict typing UnableToLinkException constructor (I've omitted the "the" to keep the line short.) What do you think?
  8. Thomas Hohn updated the commit message in patch set 3 V +1 03/08/23, 12:16

  9. Thomas Hohn commented on patch set 3 03/08/23, 12:16

    Reply

    I changed it to: [TASK] Added todo for strictly typing class UnableToLinkException Since it's both the constructor and the class variable that are affected
  10. Oliver Klee updated the commit message in patch set 4 03/08/23, 12:18

  11. Oliver Klee voted on patch set 4 V +1 CR +1 03/08/23, 12:19

  12. core-ci voted on patch set 3 V +1 03/08/23, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38652

  13. core-ci voted on patch set 4 V +1 03/08/23, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38653

  14. Georg Ringer voted on patch set 4 V +1 CR +1 03/08/23, 14:21

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 03/14/23, 13:50

  16. Christian Kuhn merged patch set 5 03/14/23, 13:50