Review 11.5 Merged

78074[BUGFIX] Fix type error in UnableToLinkException->getLinkText

Thomas Hohn CR +2 V +2 Easy +6 −2 updated 03/14/23, 13:48

Commit message

The type hint indicates, that $linkText should be of type string.
However this is not always the case. In TYPO3 v11, it can contain
an instance of LinkResult.
The code has been refactored in TYPO3 v12 and since the
potential code has been removed from ContentObjectRenderer this
fix is to be considered temporary.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Thomas Hohn uploaded patch set 1 03/08/23, 11:28

  2. Oliver Klee commented on patch set 1 03/08/23, 11:55

    UnableToLinkException.php:38

    We should also adapt the type here to avoid the PHPStan warning (and so that the type makes sense: @param LinkResult|string $linkText
  3. Thomas Hohn commented on patch set 1 03/08/23, 12:11

    UnableToLinkException.php:38 Reply

    Ack
  4. Thomas Hohn uploaded patch set 2 03/08/23, 12:18

  5. Oliver Klee voted on patch set 2 CR +1 03/08/23, 12:23

  6. core-ci voted on patch set 1 V -1 03/08/23, 12:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38651

  7. core-ci voted on patch set 2 V +1 03/08/23, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38654

  8. Oliver Klee voted on patch set 2 V +1 03/08/23, 13:31

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 03/14/23, 13:48

  10. Christian Kuhn merged patch set 3 03/14/23, 13:48