Review main Merged

78076[BUGFIX] Avoid multiple undefined array keys in FileContentParser

Daniel Hettler CR +2 V +2 Easy +4 −4 updated 03/09/23, 10:27

Commit message

When indexing files the FileContentParser collects some metadata e.g. title, description and keywords. For some files these information are not given and the parser breaks in an PHP 8 environment.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Thomas Hohn +1
    • Oliver Klee +1
    • Albrecht Köhnlein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Albrecht Köhnlein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Daniel Hettler uploaded patch set 1 03/08/23, 16:36

  2. core-ci voted on patch set 1 V +1 03/08/23, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38661

  3. Oliver Klee voted on patch set 1 CR +1 03/08/23, 17:20

  4. Thomas Hohn commented on patch set 1 CR -1 03/08/23, 17:22

  5. Daniel Hettler updated the commit message in patch set 2 CR +1 V +1 03/08/23, 17:30

  6. core-ci voted on patch set 2 V +1 03/08/23, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38663

  7. Thomas Hohn voted on patch set 2 CR +1 03/08/23, 17:48

  8. Oliver Klee voted on patch set 2 CR +1 03/08/23, 18:07

  9. Albrecht Köhnlein voted on patch set 2 V +1 CR +1 03/09/23, 07:39

  10. Benni Mack voted on patch set 2 V +2 CR +2 03/09/23, 10:27

  11. Benni Mack merged patch set 3 03/09/23, 10:27