Review main Merged

78077[FEATURE] Make PSR-7 request accessible for authentication services

Torben Hansen CR +2 V +2 Normal +60 −14 updated 03/14/23, 16:08

Commit message

Custom TYPO3 authentication services can now directly
access the PSR-7 Request object via the $authInfo array,
handed over to the initAuth() method of those services.
This therefore allows to further reduce usages of PHP
super globals and `GeneralUtility::getIndpEnv()`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1114

  1. Torben Hansen uploaded patch set 1 03/08/23, 18:39

  2. core-ci voted on patch set 1 V +1 03/08/23, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38666

  3. Benni Mack uploaded patch set 2 V +1 03/09/23, 10:35

  4. core-ci voted on patch set 2 V +1 03/09/23, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38690

  5. Jörg Bösche voted on patch set 2 CR +1 03/10/23, 07:27

  6. Benni Mack voted on patch set 2 V +1 CR +1 03/14/23, 15:22

  7. Oli Bartsch commented on patch set 2 CR -1 03/14/23, 15:26

    on it
  8. Christian Kuhn voted on patch set 2 V +1 CR +1 03/14/23, 15:26

  9. Christian Kuhn voted on patch set 2 V 0 CR 0 03/14/23, 15:27

  10. Oli Bartsch uploaded patch set 3 CR +1 V +1 03/14/23, 15:53

  11. core-ci voted on patch set 3 V +1 03/14/23, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38936

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 03/14/23, 16:04

  13. Benni Mack voted on patch set 3 V +2 CR +2 03/14/23, 16:08

  14. Benni Mack merged patch set 4 03/14/23, 16:08