78078[BUGFIX] Explicitly import `Viewport` in LiveSearch
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1417
-
Andreas Kienast uploaded patch set 1 03/09/23, 07:50
-
core-ci voted on patch set 1 V +1 03/09/23, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38677
-
Markus Klein commented on patch set 1 03/09/23, 08:06
did u mean "undefined"? -
Andreas Kienast commented on patch set 1 03/09/23, 08:21
Reply
No, why? If it would be undefined, the code wouldn't work at all? -
Markus Klein commented on patch set 1 03/09/23, 08:26
Reply
Then I don't get what the sentence should say. Or is the "somewhere" misplaced? And it should read "is defined somewhere"? -
Oliver Hader commented on patch set 1 CR +1 03/09/23, 08:28
Reply
I think should be `... is defined somewhere ...` when those imported module dependencies are evaluated. For instance the now imported `viewport.ts` is doing this assignment to `top.TYPO3.Backend = viewportObject;`. -
Oliver Hader voted on patch set 1 V +1 03/09/23, 11:12
-
Andreas Kienast uploaded patch set 2
CR +1V +103/09/23, 11:39 -
Andreas Kienast updated the commit message in patch set 3 03/09/23, 11:40
-
core-ci voted on patch set 2 V +1 03/09/23, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38694
-
core-ci voted on patch set 3 V +1 03/09/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38695
-
Georg Ringer voted on patch set 3 V +1 CR +1 03/09/23, 13:22
-
Christian Kuhn voted on patch set 3 V +1 CR +1 03/14/23, 13:51
-
Oli Bartsch voted on patch set 3 V +1 CR +1 03/14/23, 16:10
-
Christian Kuhn voted on patch set 3 V +2 CR +2 03/14/23, 16:22
-
Christian Kuhn merged patch set 4 03/14/23, 16:22
-
Christian Kuhn commented on patch set 4 03/14/23, 16:22
Reply
Done