Review main Merged

78078[BUGFIX] Explicitly import `Viewport` in LiveSearch

Andreas Kienast CR +2 V +2 Easy +5 −4 updated 03/14/23, 16:22

Commit message

The result container in LiveSearch used to use `TYPO3.Backend` to access
the righthand module container of the TYPO3 backend scaffold, which is
bad practice as the dependency is defined somewhere. It's better to
explicitly import the `Viewport` module, providing the same
functionality.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1417

  1. Andreas Kienast uploaded patch set 1 03/09/23, 07:50

  2. core-ci voted on patch set 1 V +1 03/09/23, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38677

  3. Markus Klein commented on patch set 1 03/09/23, 08:06

    did u mean "undefined"?
  4. Andreas Kienast commented on patch set 1 03/09/23, 08:21

    Reply

    No, why? If it would be undefined, the code wouldn't work at all?
  5. Markus Klein commented on patch set 1 03/09/23, 08:26

    Reply

    Then I don't get what the sentence should say. Or is the "somewhere" misplaced? And it should read "is defined somewhere"?
  6. Oliver Hader commented on patch set 1 CR +1 03/09/23, 08:28

    Reply

    I think should be `... is defined somewhere ...` when those imported module dependencies are evaluated. For instance the now imported `viewport.ts` is doing this assignment to `top.TYPO3.Backend = viewportObject;`.
  7. Oliver Hader voted on patch set 1 V +1 03/09/23, 11:12

  8. Andreas Kienast uploaded patch set 2 CR +1 V +1 03/09/23, 11:39

  9. Andreas Kienast updated the commit message in patch set 3 03/09/23, 11:40

  10. core-ci voted on patch set 2 V +1 03/09/23, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38694

  11. core-ci voted on patch set 3 V +1 03/09/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38695

  12. Georg Ringer voted on patch set 3 V +1 CR +1 03/09/23, 13:22

  13. Christian Kuhn voted on patch set 3 V +1 CR +1 03/14/23, 13:51

  14. Oli Bartsch voted on patch set 3 V +1 CR +1 03/14/23, 16:10

  15. Christian Kuhn voted on patch set 3 V +2 CR +2 03/14/23, 16:22

  16. Christian Kuhn merged patch set 4 03/14/23, 16:22

  17. Christian Kuhn commented on patch set 4 03/14/23, 16:22

    Reply

    Done