78079[BUGFIX] Check if directory is valid before processing it
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1112
-
Georg Ringer uploaded patch set 1 03/09/23, 08:17
-
Georg Ringer commented on patch set 1 03/09/23, 08:17
This change is ready for review. -
core-ci voted on patch set 1 V +1 03/09/23, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38678
-
Oliver Klee voted on patch set 1 CR +1 03/09/23, 08:40
-
Josef Glatz commented on patch set 1 CR +1 03/09/23, 10:56
by reading. can test later -
Stefan Bürk commented on patch set 1 03/09/23, 11:13
From reading seems fine. Georg, can you cover this with a test ? -
Georg Ringer commented on patch set 1 03/10/23, 07:40
tbh don't know how to exactly test that but without this patch, the full backend is broken and can't be repaired -
Oliver Klee voted on patch set 1 CR 0 03/10/23, 10:22
-
Sybille Peters voted on patch set 1 V +1 CR +1 03/12/23, 14:16
-
Christian Kuhn commented on patch set 1 CR -1 03/13/23, 16:16
Reply Unresolved
the existing coverage has tons of examples, it should be easy to add another one that comes with a broken directory declaration. which issue did you stumble upon when looking at it? -
Christian Kuhn commented on patch set 1 03/14/23, 16:11
abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/78125 which comes with a test for this case. -
Christian Kuhn abandoned the change 03/14/23, 16:11