Review 11.5 Merged

78081[BUGFIX] Fix incorrect type annotation for GU::makeInstance

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 03/09/23, 13:04

Commit message

For variable arguments, the type annotation needs to match the
type of the single arguments, not an array of the single arguments.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Nikita Hovratov uploaded patch set 1 03/09/23, 12:29

  2. core-ci voted on patch set 1 V +1 03/09/23, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38697

  3. Oliver Klee voted on patch set 1 CR +1 03/09/23, 12:44

  4. Nikita Hovratov voted on patch set 1 V +2 CR +2 03/09/23, 13:04

  5. Nikita Hovratov merged patch set 2 03/09/23, 13:04