Review 11.5 Merged

78086[BUGFIX] Fix array access in ImageContentObject

Thomas Hohn CR +2 V +2 Easy +3 −3 updated 03/13/23, 22:35

Commit message

If an image has been deleted and marked missing in
sys_file, the cImage method tries to access $info[3]
which is null.
Added a null coalescing operator around the access
to $info[3].
The code has been rewritten in TYPO3 v12 and will
ensure that value of $info[3] is a string.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Thomas Hohn uploaded patch set 1 03/10/23, 06:40

  2. Jörg Bösche voted on patch set 1 CR +1 03/10/23, 07:22

  3. core-ci voted on patch set 1 V -1 03/10/23, 07:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38727

  4. Thomas Hohn uploaded patch set 2 CR +1 V -1 03/10/23, 08:33

  5. core-ci voted on patch set 2 V +1 03/10/23, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38757

  6. Oliver Klee voted on patch set 2 CR +1 03/10/23, 10:20

  7. Chris Müller voted on patch set 2 CR +1 03/10/23, 21:03

  8. Markus Klein updated the commit message in patch set 3 CR +1 V +1 03/10/23, 21:25

  9. Markus Klein voted on patch set 3 V +1 CR +1 03/10/23, 21:26

  10. Oliver Klee voted on patch set 3 CR +1 03/10/23, 21:28

  11. core-ci voted on patch set 3 V +1 03/10/23, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38778

  12. Benni Mack voted on patch set 3 V +2 CR +2 03/13/23, 22:35

  13. Benni Mack merged patch set 4 03/13/23, 22:35