78090[BUGFIX] SystemStatusUpdateTask missing url when sent via cron
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1314
-
Thomas Hohn uploaded patch set 1 03/10/23, 13:32
-
core-ci voted on patch set 1 V +1 03/10/23, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38771
-
Markus Klein commented on patch set 1 03/10/23, 21:28
-
Thomas Hohn commented on patch set 1 03/11/23, 06:00
SystemEmail.txt:4ReplyThats a good question - do you have a better way to retrieve it? -
Thomas Hohn commented on patch set 1 03/11/23, 07:04
SystemEmail.txt:4ReplyAlternatively in cli context - get the first site via GeneralUtility::makeInstance(SiteFinder::class)->getAllSites();? -
Markus Klein commented on patch set 1 03/11/23, 07:33
SystemEmail.txt:4ReplyTo be honest: The URL does not make sense at all in this mail's context. This is a status report of the full instance, it has nothing to do with a specific domain. I would simply drop this information completely, it has no additional value over the site's name. -
Thomas Hohn commented on patch set 1 03/11/23, 07:42
SystemEmail.txt:4ReplyHi - makes sense - but then I think we should drop it both in the cli and non cli case. -
Markus Klein commented on patch set 1 03/11/23, 11:42
SystemEmail.txt:4ReplyAck -
Thomas Hohn commented on patch set 1 03/11/23, 12:45
SystemEmail.txt:4ReplyAnd BTW - is there as reason for excluding these informations when invoking it from cli context? // Only add the environment status report if not in CLI mode if (!Environment::isCli()) { $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['reports']['tx_reports']['status']['providers']['system'][] = EnvironmentStatusReport::class; } -
Markus Klein commented on patch set 1 03/11/23, 13:29
SystemEmail.txt:4Replyhttps://review.typo3.org/c/Packages/TYPO3.CMS/+/74201/13/typo3/sysext/install/Classes/Report/EnvironmentStatusReport.php probably due to the FlashMessages -
Thomas Hohn abandoned the change 03/12/23, 16:28
Part of this issue will be solved by #78101 -
Sybille Peters commented on patch set 1 03/12/23, 21:54
I don't quite understand why you abandoned. I was just about to comment. I would see our patches as duplicates (more or less) and since yours was created first, to be polite, I would abandon mine. If you want, you can reopen. Or we can continue in https://review.typo3.org/c/Packages/TYPO3.CMS/+/78101. Both is ok with me 😊SystemEmail.txt:4Reply UnresolvedI agree that setting the site specific information (URI and sitename) may not make sense in some contexts. I think the site specific information can be removed from the footer, OR displaying it can be done with an if condition: <f:if condition={typo3.sitename} ... etc. -
Sybille Peters commented on patch set 1 03/12/23, 21:56
SystemEmail.txt:3About typo3.sitename, see See typo3/sysext/core/Classes/Mail/FluidEmail.php: 'sitename' => $GLOBALS['TYPO3_CONF_VARS']['SYS']['sitename'], It is not an URI. It is the site decription. -
Thomas Hohn commented on patch set 1 03/13/23, 10:57
SystemEmail.txt:3Reply UnresolvedHi - the orginal issue contains more than one issue. I'll make a task toi remove it and the original #100103 should be investigated further
SystemEmail.txt:4