Review main Merged

78091[TASK] Use native types for mock objects

Oliver Klee CR +2 V +2 Hard +75 −234 updated 03/14/23, 14:58

Commit message

Also add the missing types and correctly use intersection types.

Also reorder the type declarations for consistency.

Also drop superfluous type annotations.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 51

Show 31 more files

Review log 57

  1. Oliver Klee uploaded patch set 1 03/10/23, 22:04

  2. core-ci voted on patch set 1 V +1 03/10/23, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38780

  3. Oliver Klee updated the commit message in patch set 2 V +1 03/10/23, 22:17

  4. core-ci voted on patch set 2 V +1 03/10/23, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38781

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 03/14/23, 14:57

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 03/14/23, 14:58

  7. Stefan Bürk merged patch set 3 03/14/23, 14:58