78096[BUGFIX] Respect nullable date time fields
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2741
Show 916 earlier messages
-
JAKOTA Design Group GmbH uploaded patch set 1 03/12/23, 09:26
-
JAKOTA Design Group GmbH commented on patch set 1 03/12/23, 09:34
Because 12.x has a new 'type' => 'datetime' this is more a patch for 11.5. But as the affected code can also be found in main I fixed it here as well. -
core-ci voted on patch set 1 V -1 03/12/23, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38817
-
JAKOTA Design Group GmbH uploaded patch set 2
V -103/12/23, 13:11 -
core-ci voted on patch set 2 V -1 03/12/23, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38831
-
JAKOTA Design Group GmbH uploaded patch set 3
V -103/12/23, 16:19 -
core-ci voted on patch set 3 V +1 03/12/23, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38832
-
JAKOTA Design Group GmbH uploaded patch set 4
V +103/12/23, 17:44 -
core-ci voted on patch set 4 V +1 03/12/23, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38837
-
JAKOTA Design Group GmbH updated the commit message in patch set 5
V +103/12/23, 18:25 -
core-ci voted on patch set 5 V +1 03/12/23, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38842
-
JAKOTA Design Group GmbH uploaded patch set 6
V +103/12/23, 21:55 -
JAKOTA Design Group GmbH uploaded patch set 7 03/12/23, 21:56
-
core-ci voted on patch set 6 V -1 03/12/23, 22:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38849
-
core-ci voted on patch set 7 V +1 03/12/23, 22:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38850
-
JAKOTA Design Group GmbH commented on patch set 7 03/12/23, 22:05
Reply
Tested with v12 (latest main) by setting 'eval' to 'time,null' or just setting 'nullable' to true. For v11.5 the line: if (($columnConfig['config']['nullable'] ?? false) === true) { must be change to if (($columnConfig['config']['nullable'] ?? false) === true || GeneralUtility::inList($columnConfig['config']['eval'] ?? '', 'null')) {
-
JAKOTA Design Group GmbH uploaded patch set 8
V +103/20/23, 14:01 -
core-ci voted on patch set 8 V +1 03/20/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39241
-
JAKOTA Design Group GmbH commented on patch set 8 04/13/23, 12:18
Hi, any news here on how to proceed? Or are nullable date time fields not supported? -
Oliver Klee updated the commit message in patch set 9
V +104/13/23, 12:38 -
core-ci voted on patch set 9 V +1 04/13/23, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40566
-
Benni Mack updated the commit message in patch set 10
V +105/03/23, 09:44 -
JAKOTA Design Group GmbH commented on patch set 10 06/06/23, 14:01
Hi, Any updates here? -
Benni Mack rebased onto patch set 11 07/04/23, 12:02
-
Benni Mack voted on patch set 11 CR +1 07/04/23, 12:03
-
Oliver Klee voted on patch set 11 V +1 07/04/23, 12:06
-
core-ci voted on patch set 11 V +1 07/04/23, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43376
-
Markus Klein updated the commit message in patch set 12
CR +1V +107/05/23, 17:53 -
core-ci voted on patch set 12 V +1 07/05/23, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43575
-
Oliver Klee voted on patch set 12 V +1 07/05/23, 18:17
-
Markus Klein uploaded patch set 13
V +107/05/23, 18:21 -
Markus Klein uploaded patch set 14 07/05/23, 18:26
-
core-ci voted on patch set 13 V -1 07/05/23, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43581
-
core-ci voted on patch set 14 V -1 07/05/23, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43583
-
Markus Klein uploaded patch set 15
V -107/05/23, 18:41 -
core-ci voted on patch set 15 V +1 07/05/23, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43590
-
Benni Mack voted on patch set 15 V +1 CR +1 07/05/23, 19:00
-
Oli Bartsch voted on patch set 15 CR +1 07/05/23, 19:04
-
Markus Klein voted on patch set 15 V +1 CR +1 07/05/23, 19:15
-
Benni Mack voted on patch set 15 V +2 CR +2 07/05/23, 19:15
-
Benni Mack merged patch set 16 07/05/23, 19:15