78098[TASK] Make parameter names of GU::revExplode consistent
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 1
Review log 910
-
Oliver Klee uploaded patch set 1 03/12/23, 10:16
-
core-ci voted on patch set 1 V +1 03/12/23, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38825
-
Georg Ringer voted on patch set 1 V +1 CR +1 03/12/23, 19:25
-
Josef Glatz voted on patch set 1 V +1 CR +1 03/13/23, 05:05
-
Nikita Hovratov commented on patch set 1 V -1 03/13/23, 09:52
-1 for now, because we didn't agree yet, if changing parameter names is breaking (when using PHP 8 named arguments). -
Benni Mack commented on patch set 1 03/13/23, 14:39
not breaking. -
Benni Mack commented on patch set 1 03/13/23, 14:40
the reasoning is: We did not define this as API in our backwards-compat docs + news, so it's not included. -
Nikita Hovratov voted on patch set 1 V 0 03/13/23, 17:33
-
Benni Mack voted on patch set 1 V +2 CR +2 03/14/23, 14:06
-
Benni Mack merged patch set 2 03/14/23, 14:06