Review main Merged

78099[TASK] Modernize array function callbacks in Extbase

Oliver Klee CR +2 V +2 Normal +71 −68 updated 03/27/23, 10:30

Commit message

- use arrow functions
- make anonymous functions static if possible
- add type declarations
- use first class callables

see https://www.php.net/manual/en/functions.first_class_callable_syntax.php

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1419

  1. Oliver Klee uploaded patch set 1 03/12/23, 10:45

  2. core-ci voted on patch set 1 V +1 03/12/23, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38826

  3. Oliver Klee updated the commit message in patch set 2 V +1 03/14/23, 11:30

  4. core-ci voted on patch set 2 V +1 03/14/23, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38914

  5. Oliver Klee updated the commit message in patch set 3 V +1 03/14/23, 12:19

  6. core-ci voted on patch set 3 V +1 03/14/23, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38917

  7. Benni Mack voted on patch set 3 CR +1 03/14/23, 20:28

  8. Nikita Hovratov commented on patch set 3 03/15/23, 11:08

    ClassSchema.php:245

    Extra space after bool =>

    ClassSchema.php:330

    Extra space after bool =>
  9. Oliver Klee commented on patch set 3 03/15/23, 11:51

    ClassSchema.php:245 Reply

    Done

    ClassSchema.php:330 Reply

    Done
  10. Oliver Klee uploaded patch set 4 CR +1 V +1 03/15/23, 11:52

  11. core-ci voted on patch set 4 V +1 03/15/23, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38978

  12. Alexander Schnitzler commented on patch set 4 V +1 CR +1 03/17/23, 08:35

    Typo3DbQueryParser.php:870

    That's an interesting syntax. Never seen this.

    ClassSchema.php:242

    `array<int<0, max>, Validate>` I know you love this but there are places I don't see any benefit at all, letting phpstan know key types and ranges. We really just handle Sets here, a data type unknown to php but all we care about is the value. No objections to leave this as is but I think it's redundant defining the int range of keys.

    ObjectAccess.php:273

    We should rename `$methodName` to `$propertyName` here as a drive by fix.
  13. Oliver Klee wrote 03/17/23, 08:59

    Topic set to extbase
  14. Oliver Klee uploaded patch set 5 CR +1 V +1 03/17/23, 09:08

  15. Oliver Klee commented on patch set 5 03/17/23, 09:17

    ClassSchema.php:242 Reply

    Done (as the range indeed is not relevant here).

    ObjectAccess.php:273 Reply

    Done
  16. Alexander Schnitzler voted on patch set 5 V +1 CR +1 03/17/23, 09:18

  17. core-ci voted on patch set 5 V +1 03/17/23, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39106

  18. Benni Mack voted on patch set 5 V +2 CR +2 03/27/23, 10:30

  19. Benni Mack merged patch set 6 03/27/23, 10:30