78099[TASK] Modernize array function callbacks in Extbase
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Alexander Schnitzler +1
-
Verified V +2 Done
- Benni Mack +2
- Alexander Schnitzler +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php1+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php+2 −2
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Method.php+4 −3
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php6+22 −19
- typo3/sysext/extbase/Classes/Reflection/ObjectAccess.php2+13 −12
- typo3/sysext/extbase/Classes/Service/CacheService.php+1 −3
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php+1 −3
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractCompositeValidator.php+2 −4
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractValidator.php+2 −4
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/OperatorTest.php+1 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+1 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/RepositoryTest.php+16 −4
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslatedSiteContentTest.php+1 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php+2 −2
Review log 1419
-
Oliver Klee uploaded patch set 1 03/12/23, 10:45
-
core-ci voted on patch set 1 V +1 03/12/23, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38826
-
Oliver Klee updated the commit message in patch set 2
V +103/14/23, 11:30 -
core-ci voted on patch set 2 V +1 03/14/23, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38914
-
Oliver Klee updated the commit message in patch set 3
V +103/14/23, 12:19 -
core-ci voted on patch set 3 V +1 03/14/23, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38917
-
Benni Mack voted on patch set 3 CR +1 03/14/23, 20:28
-
Nikita Hovratov commented on patch set 3 03/15/23, 11:08
ClassSchema.php:330Extra space after bool => -
Oliver Klee commented on patch set 3 03/15/23, 11:51
ClassSchema.php:245ReplyDoneClassSchema.php:330ReplyDone -
Oliver Klee uploaded patch set 4
CR +1V +103/15/23, 11:52 -
core-ci voted on patch set 4 V +1 03/15/23, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38978
-
Alexander Schnitzler commented on patch set 4 V +1 CR +1 03/17/23, 08:35
Typo3DbQueryParser.php:870That's an interesting syntax. Never seen this.ClassSchema.php:242`array<int<0, max>, Validate>` I know you love this but there are places I don't see any benefit at all, letting phpstan know key types and ranges. We really just handle Sets here, a data type unknown to php but all we care about is the value. No objections to leave this as is but I think it's redundant defining the int range of keys.ObjectAccess.php:273We should rename `$methodName` to `$propertyName` here as a drive by fix. -
Oliver Klee wrote 03/17/23, 08:59
Topic set to extbase -
Oliver Klee uploaded patch set 5
CR +1V +103/17/23, 09:08 -
Oliver Klee commented on patch set 5 03/17/23, 09:17
ClassSchema.php:242ReplyDone (as the range indeed is not relevant here).ObjectAccess.php:273ReplyDone -
Alexander Schnitzler voted on patch set 5 V +1 CR +1 03/17/23, 09:18
-
core-ci voted on patch set 5 V +1 03/17/23, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39106
-
Benni Mack voted on patch set 5 V +2 CR +2 03/27/23, 10:30
-
Benni Mack merged patch set 6 03/27/23, 10:30
ClassSchema.php:245