78101[BUGFIX] Only set URL in SystemEmail if URL is given.
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 78
-
Sybille Peters uploaded patch set 1 03/12/23, 11:09
-
core-ci voted on patch set 1 V +1 03/12/23, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38828
-
Thomas Hohn commented on patch set 1 CR -1 03/12/23, 16:27
-
Sybille Peters commented on patch set 1 03/12/23, 17:40
SystemEmail.txt:4ReplyThe URL that is passed is the site URL, not the URL of a specific page. Also, if there is no value here (e.g. in cli), the URL will not be displayed. What is the problem with displaying the site URL? -
Thomas Hohn commented on patch set 1 03/12/23, 18:13
SystemEmail.txt:4ReplyThe information is for the whole instance, so multisites is an good example. Or see my discussion with Markus in https://review.typo3.org/c/Packages/TYPO3.CMS/+/78090 -
Sybille Peters commented on patch set 1 CR -1 03/12/23, 21:39
SystemEmail.txt:4ReplyI don't think there is much point to continue here, as the patch seems to be a duplicate of https://review.typo3.org/c/Packages/TYPO3.CMS/+/78090 and it does not make sense to discuss it in 2 places. I will take a look. -
Sybille Peters commented on patch set 1 03/12/23, 22:01
Waiting if https://review.typo3.org/c/Packages/TYPO3.CMS/+/78090 is reopened. If yes, we can close the patch and issue as duplicate.SystemEmail.html:422Unresolved{typo3.sitename} should be checked as wellSystemEmail.txt:4Reply UnresolvedI understood what you -
Sybille Peters abandoned the change 03/13/23, 11:24
Was partially duplicate with https://review.typo3.org/c/Packages/TYPO3.CMS/+/78090 Abandon for now to avoid confusion with too many open issues and patches.
SystemEmail.txt:4