Review main Abandoned

78101[BUGFIX] Only set URL in SystemEmail if URL is given.

Sybille Peters CR 0 V 0 Easy +3 −2 updated 03/13/23, 11:24

Commit message

The Fluid layout SystemEmail can be used by default for sending emails.
If the email is sent via cli (command line), the URL is not set and
should not be displayed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 78

  1. Sybille Peters uploaded patch set 1 03/12/23, 11:09

  2. core-ci voted on patch set 1 V +1 03/12/23, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38828

  3. Thomas Hohn commented on patch set 1 CR -1 03/12/23, 16:27

    SystemEmail.txt:4

    Why not skip the URL in both cases. The information provided in the email is related to the whole site and not a specific ULR. In addition normalizedParams.siteUrl is never set in cli context
  4. Sybille Peters commented on patch set 1 03/12/23, 17:40

    SystemEmail.txt:4 Reply

    The URL that is passed is the site URL, not the URL of a specific page. Also, if there is no value here (e.g. in cli), the URL will not be displayed. What is the problem with displaying the site URL?
  5. Thomas Hohn commented on patch set 1 03/12/23, 18:13

    SystemEmail.txt:4 Reply

    The information is for the whole instance, so multisites is an good example. Or see my discussion with Markus in https://review.typo3.org/c/Packages/TYPO3.CMS/+/78090
  6. Sybille Peters commented on patch set 1 CR -1 03/12/23, 21:39

    SystemEmail.txt:4 Reply

    I don't think there is much point to continue here, as the patch seems to be a duplicate of https://review.typo3.org/c/Packages/TYPO3.CMS/+/78090 and it does not make sense to discuss it in 2 places. I will take a look.
  7. Sybille Peters commented on patch set 1 03/12/23, 22:01

    Waiting if https://review.typo3.org/c/Packages/TYPO3.CMS/+/78090 is reopened. If yes, we can close the patch and issue as duplicate.

    SystemEmail.html:422 Unresolved

    {typo3.sitename} should be checked as well

    SystemEmail.txt:4 Reply Unresolved

    I understood what you
  8. Sybille Peters abandoned the change 03/13/23, 11:24

    Was partially duplicate with https://review.typo3.org/c/Packages/TYPO3.CMS/+/78090 Abandon for now to avoid confusion with too many open issues and patches.