Review main Merged

78102[TASK] Add Content-Security-Policy hash declarations

Oliver Hader CR +2 V +2 Hard +532 −47 updated 03/27/23, 14:20

Commit message

Add the possibility to extend the Content-Security-Policy model by
cryptographic hashes - which can either be static or a dynamic proxy:

* `$type = HashType::sha256;`
* `new HashValue('<base64-hash>', $type);`
* `HashProxy::glob('EXT:my/Resources/Public/*.js')->withType($type);`
* `HashProxy::urls('https://example.org/worker.js')->withType($type);`

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 17

Review log 1116

  1. Oliver Hader uploaded patch set 1 03/12/23, 12:09

  2. Oliver Hader uploaded patch set 2 03/12/23, 12:41

  3. core-ci voted on patch set 1 V -1 03/12/23, 12:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38829

  4. core-ci voted on patch set 2 V +1 03/12/23, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38830

  5. Oliver Hader uploaded patch set 3 V +1 03/15/23, 09:27

  6. core-ci voted on patch set 3 V +1 03/15/23, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38964

  7. Oliver Hader uploaded patch set 4 V +1 03/27/23, 10:25

  8. core-ci voted on patch set 4 V -1 03/27/23, 10:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39680

  9. Oliver Hader uploaded patch set 5 V -1 03/27/23, 11:32

  10. Oliver Hader marked it ready for review 03/27/23, 11:32

  11. Oliver Hader commented on patch set 5 03/27/23, 11:37

    SourceCollection.php:21

    Yes, `Nonce` was dropped on purpose and has to use the `nonce-proxy` enum value.
  12. core-ci voted on patch set 5 V +1 03/27/23, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39685

  13. Benni Mack voted on patch set 5 V +1 CR +1 03/27/23, 13:20

  14. Andreas Kienast voted on patch set 5 CR +2 03/27/23, 14:16

  15. Andreas Kienast voted on patch set 5 V +2 03/27/23, 14:20

  16. Andreas Kienast merged patch set 6 03/27/23, 14:20