Review main Merged

78103[TASK] Use native types in ext:fluid_styled_content tests

Torben Hansen CR +2 V +2 Easy +1 −4 updated 03/13/23, 21:04

Commit message

This change adds a native type declaration for the
property `$contentFields` in `ContentVisibleFieldsTest`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Torben Hansen uploaded patch set 1 03/12/23, 17:27

  2. core-ci voted on patch set 1 V +1 03/12/23, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38835

  3. Oliver Klee voted on patch set 1 V +1 CR +1 03/12/23, 17:36

  4. Oliver Klee updated the commit message in patch set 2 CR +1 V +1 03/12/23, 17:36

  5. Oliver Klee voted on patch set 2 V +1 CR +1 03/12/23, 17:36

  6. core-ci voted on patch set 2 V +1 03/12/23, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38836

  7. Georg Ringer voted on patch set 2 V +1 CR +1 03/12/23, 19:05

  8. Benni Mack voted on patch set 2 V +2 CR +2 03/13/23, 21:04

  9. Benni Mack merged patch set 3 03/13/23, 21:04