Review main Merged

78107[BUGFIX] Avoid "field doesn't have a default value" sql error

Stefan Bürk CR +2 V +2 Easy +1 −0 updated 03/13/23, 16:05

Commit message

Creating new `ext:reactions` records are broken and emits an
sql error message. This happens when it's tried to switch to
the core-shipped type.

>> 2: SQL error: "Field 'fields' doesn't have a default value"

Using a default value on database level does not work with
all database backends TYPO3 v12 officially supports, which
has been tried with #100088 and mitigated with #100101. So
that's not an option here.

This change bakes the default value for `json` type fields
using TCA default setting again, which has been the way the
original `type=user dbType=JSON` variant used with #99226.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Frank Nägler +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Frank Nägler +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 5

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 03/13/23, 13:56

  2. core-ci voted on patch set 1 V +1 03/13/23, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38879

  3. Frank Nägler voted on patch set 1 V +1 CR +1 03/13/23, 16:00

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 03/13/23, 16:04

  5. Stefan Bürk voted on patch set 1 V +2 CR +2 03/13/23, 16:05

  6. Stefan Bürk merged patch set 2 03/13/23, 16:05