Review main Merged

78110[TASK] Cleanup ext:lowlevel

Torben Hansen CR +2 V +2 Normal +31 −96 updated 03/14/23, 16:24

Commit message

This change cleans up parts of ext:lowlevel by

* using constructor property promotion where possible
* using typesafe comparison for command option `dry-run`
* removing superfluous typehints in doc headers
* adding missing typehints in doc headers
* using strict comparison where possible
* adding function parameter type declaration where suitable
* adding missing function return types
* fixing a typo in `ProviderRegistry`

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 810

  1. Torben Hansen uploaded patch set 1 03/13/23, 18:44

  2. Oliver Klee commented on patch set 1 03/13/23, 18:54

    Look all in all very good! I’ve added two smaller remarks.

    DeletedRecordsCommand.php:299

    We can remove this line as it doesn’t add anything over the native type declaration.

    ProviderInterface.php:33

    `@return $this` should stay as it adds information to PHPStan that the returned instance is the called instance (instead of only any instance of the same class).
  3. core-ci voted on patch set 1 V -1 03/13/23, 19:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38887

  4. Torben Hansen uploaded patch set 2 V -1 03/14/23, 06:05

  5. Torben Hansen commented on patch set 1 03/14/23, 06:05

    DeletedRecordsCommand.php:299 Reply

    Done

    ProviderInterface.php:33 Reply

    Done
  6. core-ci voted on patch set 2 V +1 03/14/23, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38900

  7. Oliver Klee voted on patch set 2 CR +1 03/14/23, 09:25

  8. Benni Mack voted on patch set 2 V +1 CR +1 03/14/23, 15:19

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 03/14/23, 16:24

  10. Christian Kuhn merged patch set 3 03/14/23, 16:24