78110[TASK] Cleanup ext:lowlevel
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php+2 −13
- typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php2+4 −14
- typo3/sysext/lowlevel/Classes/Command/MissingRelationsCommand.php+5 −15
- typo3/sysext/lowlevel/Classes/Command/OrphanRecordsCommand.php+4 −10
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/BackendRoutesProvider.php+1 −4
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/EventListenersProvider.php+1 −4
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/HttpMiddlewareStackProvider.php+1 −4
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/MfaProvidersProvider.php+1 −4
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/ProviderInterface.php2+0 −1
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/ProviderRegistry.php+2 −2
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/SoftReferenceParsersProvider.php+1 −4
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/ToolbarItemsProvider.php+1 −4
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+8 −17
Review log 810
-
Torben Hansen uploaded patch set 1 03/13/23, 18:44
-
Oliver Klee commented on patch set 1 03/13/23, 18:54
Look all in all very good! I’ve added two smaller remarks.DeletedRecordsCommand.php:299We can remove this line as it doesn’t add anything over the native type declaration.ProviderInterface.php:33`@return $this` should stay as it adds information to PHPStan that the returned instance is the called instance (instead of only any instance of the same class). -
core-ci voted on patch set 1 V -1 03/13/23, 19:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38887
-
Torben Hansen uploaded patch set 2
V -103/14/23, 06:05 -
Torben Hansen commented on patch set 1 03/14/23, 06:05
DeletedRecordsCommand.php:299ReplyDoneProviderInterface.php:33ReplyDone -
core-ci voted on patch set 2 V +1 03/14/23, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38900
-
Oliver Klee voted on patch set 2 CR +1 03/14/23, 09:25
-
Benni Mack voted on patch set 2 V +1 CR +1 03/14/23, 15:19
-
Christian Kuhn voted on patch set 2 V +2 CR +2 03/14/23, 16:24
-
Christian Kuhn merged patch set 3 03/14/23, 16:24