Review main Abandoned

78115[BUGFIX] Prevent concurrent image processing

Daniel Siepmann CR 0 V 0 Easy +10 −2 updated 05/08/23, 06:52

Commit message

Add locking to image processing.
This prevents that the same image is processed the same way
concurrently. The concurrent processing will lead to a missing processed
file which would be kept in the system.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 46

  1. Daniel Siepmann uploaded patch set 1 03/14/23, 07:41

  2. core-ci voted on patch set 1 V +1 03/14/23, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38904

  3. Markus Klein commented on patch set 1 V -1 CR -1 03/14/23, 09:18

    FileProcessingService.php:134 Unresolved

    This is pretty dangerous! The number of locks in the system scales with the number of images! If you use semaphore locks (unix system resources) you potentially kill the whole server completely. (by default we have file-system based locks, though) You need to solve this with a 2-layer approach. A global "access lock" that protects a critical area, which then again uses a (non-blocking) lock for the specific file. This is the exact same approach we use for generating FE output. Look at the implementation there please
  4. Benni Mack updated the commit message in patch set 2 CR -1 V +1 05/03/23, 09:35

  5. core-ci voted on patch set 2 V +1 05/03/23, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41432

  6. Daniel Siepmann abandoned the change 05/08/23, 06:52

    Our customer doesn't pay as much as I probably would need to implement a proper solution. Feel free to pick this up again. I've commented our workaround within the issue.