Review main Merged

78116[TASK] Lift type restriction in CommandApplication

Helmut Hummel CR +2 V +2 Easy +2 −1 updated 03/14/23, 10:15

Commit message

Instead of requiring strictly the TYPO3 implementation of a console Application,
the property is allowed to hold an instance of the base application class.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Oliver Klee +1
    • Markus Klein +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Markus Klein +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Helmut Hummel uploaded patch set 1 03/14/23, 09:41

  2. Helmut Hummel voted on patch set 1 V +2 CR +2 03/14/23, 09:44

  3. Markus Klein voted on patch set 1 V +1 CR +1 03/14/23, 09:44

  4. Oliver Klee voted on patch set 1 CR +1 03/14/23, 09:46

  5. core-ci voted on patch set 1 V +1 03/14/23, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38906

  6. Benni Mack commented on patch set 1 V +1 CR +1 03/14/23, 10:05

    totally
  7. Stefan Bürk voted on patch set 1 V +1 CR +1 03/14/23, 10:15

  8. Helmut Hummel merged patch set 2 03/14/23, 10:15

  9. Helmut Hummel commented on patch set 2 03/14/23, 10:15

    Thank you very much!!!